diff options
| author | Craig Topper <craig.topper@sifive.com> | 2025-07-22 08:06:30 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-07-22 08:06:30 -0700 |
| commit | 8d549cf036b6facf455b9add2d878012dfeb3d0d (patch) | |
| tree | 68fc5ba9bfee5f9f87cb4f2ba577896c5a9a35fc /llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp | |
| parent | d5099722e8ae0972a4a95927cb8ed415eda17298 (diff) | |
| download | llvm-8d549cf036b6facf455b9add2d878012dfeb3d0d.zip llvm-8d549cf036b6facf455b9add2d878012dfeb3d0d.tar.gz llvm-8d549cf036b6facf455b9add2d878012dfeb3d0d.tar.bz2 | |
[SelectionDAG] Pass SDNodeFlags through getNode instead of setFlags. (#149852)
getNode updates flags correctly for CSE. Calling setFlags after getNode
may set the flags where they don't apply.
I've added a Flags argument to getSelectCC and the signature of getNode that takes
an ArrayRef of EVTs.
Diffstat (limited to 'llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp')
| -rw-r--r-- | llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp b/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp index f908a66..d2ecc133 100644 --- a/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp @@ -2087,11 +2087,10 @@ void VectorLegalizer::ExpandSETCC(SDNode *Node, // Otherwise, SETCC for the given comparison type must be completely // illegal; expand it into a SELECT_CC. EVT VT = Node->getValueType(0); - LHS = - DAG.getNode(ISD::SELECT_CC, dl, VT, LHS, RHS, - DAG.getBoolConstant(true, dl, VT, LHS.getValueType()), - DAG.getBoolConstant(false, dl, VT, LHS.getValueType()), CC); - LHS->setFlags(Node->getFlags()); + LHS = DAG.getNode(ISD::SELECT_CC, dl, VT, LHS, RHS, + DAG.getBoolConstant(true, dl, VT, LHS.getValueType()), + DAG.getBoolConstant(false, dl, VT, LHS.getValueType()), + CC, Node->getFlags()); } Results.push_back(LHS); |