diff options
author | Matt Arsenault <Matthew.Arsenault@amd.com> | 2025-02-21 22:11:51 +0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-02-21 22:11:51 +0700 |
commit | 34167f99668ce4d4d6a1fb88453a8d5b56d16ed5 (patch) | |
tree | 6cbf97b75cb0f2e7cf38d401af04071ef242a523 /llvm/lib/CodeGen/RegAllocBasic.cpp | |
parent | d578dbf9fdb4ce5cba13dda88393c2a67e61a30c (diff) | |
download | llvm-34167f99668ce4d4d6a1fb88453a8d5b56d16ed5.zip llvm-34167f99668ce4d4d6a1fb88453a8d5b56d16ed5.tar.gz llvm-34167f99668ce4d4d6a1fb88453a8d5b56d16ed5.tar.bz2 |
RegAlloc: Fix verifier error after failed allocation (#119690)
In some cases after reporting an allocation failure, this would fail
the verifier. It picks the first allocatable register and assigns it,
but didn't update the liveness appropriately. When VirtRegRewriter
relied on the liveness to set kill flags, it would incorrectly add
kill flags if there was another overlapping kill of the virtual
register.
We can't properly assign the register to an overlapping range, so
break the liveness of the failing register (and any other interfering
registers) instead. Give the virtual register dummy liveness by
effectively deleting all the uses by setting them to undef.
The edge case not tested here which I'm worried about is if the read
of the register is a def of a subregister. I've been unable to come up
with a test where this occurs.
https://reviews.llvm.org/D122616
Diffstat (limited to 'llvm/lib/CodeGen/RegAllocBasic.cpp')
-rw-r--r-- | llvm/lib/CodeGen/RegAllocBasic.cpp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/llvm/lib/CodeGen/RegAllocBasic.cpp b/llvm/lib/CodeGen/RegAllocBasic.cpp index 51e047b..d240bf9 100644 --- a/llvm/lib/CodeGen/RegAllocBasic.cpp +++ b/llvm/lib/CodeGen/RegAllocBasic.cpp @@ -329,6 +329,7 @@ bool RABasic::runOnMachineFunction(MachineFunction &mf) { allocatePhysRegs(); postOptimization(); + cleanupFailedVRegs(); // Diagnostic output before rewriting LLVM_DEBUG(dbgs() << "Post alloc VirtRegMap:\n" << *VRM << "\n"); |