diff options
author | Sam McCall <sam.mccall@gmail.com> | 2020-06-26 12:57:29 +0200 |
---|---|---|
committer | Sam McCall <sam.mccall@gmail.com> | 2020-07-01 00:52:08 +0200 |
commit | ffa63dde8e97a34b8914a151556551f74d4227e7 (patch) | |
tree | 5135b48b5bb33c40087e2fe496afadd599cbc151 /llvm/lib/CodeGen/ModuloSchedule.cpp | |
parent | b210c9899bddf4c0332f8295b3b71938299e4835 (diff) | |
download | llvm-ffa63dde8e97a34b8914a151556551f74d4227e7.zip llvm-ffa63dde8e97a34b8914a151556551f74d4227e7.tar.gz llvm-ffa63dde8e97a34b8914a151556551f74d4227e7.tar.bz2 |
[clangd] Run formatting operations asynchronously.
Summary:
They don't need ASTs or anything, so they should still run immediately.
These were sync for historical reasons (they predate clangd having a pervasive
threading model). This worked ok as they were "cheap".
Aside for consistency, there are a couple of reasons to make them async:
- they do IO (finding .clang-format) so aren't trivially cheap
- having TUScheduler involved in running these tasks means we can use it as
an injection point for configuration.
(TUScheduler::run will need to learn about which file is being operated on,
but that's an easy change).
- adding the config system adds more potential IO, too
Reviewers: kbobyrev
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D82642
Diffstat (limited to 'llvm/lib/CodeGen/ModuloSchedule.cpp')
0 files changed, 0 insertions, 0 deletions