diff options
author | Balazs Benics <benicsbalazs@gmail.com> | 2022-10-13 08:41:31 +0200 |
---|---|---|
committer | Balazs Benics <benicsbalazs@gmail.com> | 2022-10-13 08:41:31 +0200 |
commit | b062ee7dc4515b0a42157717105839627d5542bb (patch) | |
tree | 633f10b02bf555e09eda8e054c0136a7376f21ce /llvm/lib/CodeGen/ModuloSchedule.cpp | |
parent | ebe9c7f3e2da779b984b336dadf37cc4ec2ae260 (diff) | |
download | llvm-b062ee7dc4515b0a42157717105839627d5542bb.zip llvm-b062ee7dc4515b0a42157717105839627d5542bb.tar.gz llvm-b062ee7dc4515b0a42157717105839627d5542bb.tar.bz2 |
[analyzer] Workaround crash on encountering Class non-type template parameters
The Clang Static Analyzer will crash on this code:
```lang=C++
struct Box {
int value;
};
template <Box V> int get() {
return V.value;
}
template int get<Box{-1}>();
```
https://godbolt.org/z/5Yb1sMMMb
The problem is that we don't account for encountering `TemplateParamObjectDecl`s
within the `DeclRefExpr` handler in the `ExprEngine`.
IMO we should create a new memregion for representing such template
param objects, to model their language semantics.
Such as:
- it should have global static storage
- for two identical values, their addresses should be identical as well
http://eel.is/c%2B%2Bdraft/temp.param#8
I was thinking of introducing a `TemplateParamObjectRegion` under `DeclRegion`
for this purpose. It could have `TemplateParamObjectDecl` as a field.
The `TemplateParamObjectDecl::getValue()` returns `APValue`, which might
represent multiple levels of structures, unions and other goodies -
making the transformation from `APValue` to `SVal` a bit complicated.
That being said, for now, I think having `Unknowns` for such cases is
definitely an improvement to crashing, hence I'm proposing this patch.
Reviewed By: xazax.hun
Differential Revision: https://reviews.llvm.org/D135763
Diffstat (limited to 'llvm/lib/CodeGen/ModuloSchedule.cpp')
0 files changed, 0 insertions, 0 deletions