diff options
author | Nicolas Vasilache <ntv@google.com> | 2020-04-09 16:36:45 -0400 |
---|---|---|
committer | Nicolas Vasilache <ntv@google.com> | 2020-04-09 16:37:28 -0400 |
commit | 2d32ee0d7a4c01209419408e73a4f075ec06c8a7 (patch) | |
tree | d2c1ef286f9245468ef6ea511d27790803669e70 /llvm/lib/CodeGen/MachineStripDebug.cpp | |
parent | 00a1032412cb86266ccd14e23752424a935bacec (diff) | |
download | llvm-2d32ee0d7a4c01209419408e73a4f075ec06c8a7.zip llvm-2d32ee0d7a4c01209419408e73a4f075ec06c8a7.tar.gz llvm-2d32ee0d7a4c01209419408e73a4f075ec06c8a7.tar.bz2 |
[mlir][Vector] Update lowering of vector ops to llvm intrinsics to use row-major.
Summary:
LLVM matrix intrinsics recently introduced an option to support row-major mode.
This matches the MLIR vector model, this revision switches to row-major.
A corner case related to degenerate sizes was also fixed upstream.
This revision removes the guard against this corner case.
A bug was uncovered on the output vector construction which this revision also fixes.
Lastly, this has been tested on a small size and benchmarked independently: no visible performance regression is observed.
In the future, when matrix intrinsics support per op attribute, we can more aggressively translate to that and avoid inserting MLIR-level transposes.
This has been tested independently to work on small matrices.
Differential Revision: https://reviews.llvm.org/D77761
Diffstat (limited to 'llvm/lib/CodeGen/MachineStripDebug.cpp')
0 files changed, 0 insertions, 0 deletions