diff options
| author | Stanislav Mekhanoshin <Stanislav.Mekhanoshin@amd.com> | 2022-09-14 15:42:30 -0700 |
|---|---|---|
| committer | Stanislav Mekhanoshin <Stanislav.Mekhanoshin@amd.com> | 2022-09-14 17:29:48 -0700 |
| commit | ef4b9c33f5dd096a4d7cd03654c17492f3802d89 (patch) | |
| tree | be13615f26d78861055f66085555c1616e6f5e6d /llvm/lib/CodeGen/MachineOperand.cpp | |
| parent | 5888c157a74b052f227b19d15dbb913cc0232f57 (diff) | |
| download | llvm-ef4b9c33f5dd096a4d7cd03654c17492f3802d89.zip llvm-ef4b9c33f5dd096a4d7cd03654c17492f3802d89.tar.gz llvm-ef4b9c33f5dd096a4d7cd03654c17492f3802d89.tar.bz2 | |
Fix crash while printing MMO target flags
MachineMemOperand::print can dereference a NULL pointer if TII
is not passed from the printMemOperand. This does not happen while
dumping the DAG/MIR from llc but crashes the debugger if a dump()
method is called from gdb.
Differential Revision: https://reviews.llvm.org/D133903
Diffstat (limited to 'llvm/lib/CodeGen/MachineOperand.cpp')
| -rw-r--r-- | llvm/lib/CodeGen/MachineOperand.cpp | 27 |
1 files changed, 18 insertions, 9 deletions
diff --git a/llvm/lib/CodeGen/MachineOperand.cpp b/llvm/lib/CodeGen/MachineOperand.cpp index 393a4f7..df52741 100644 --- a/llvm/lib/CodeGen/MachineOperand.cpp +++ b/llvm/lib/CodeGen/MachineOperand.cpp @@ -1114,15 +1114,24 @@ void MachineMemOperand::print(raw_ostream &OS, ModuleSlotTracker &MST, OS << "dereferenceable "; if (isInvariant()) OS << "invariant "; - if (getFlags() & MachineMemOperand::MOTargetFlag1) - OS << '"' << getTargetMMOFlagName(*TII, MachineMemOperand::MOTargetFlag1) - << "\" "; - if (getFlags() & MachineMemOperand::MOTargetFlag2) - OS << '"' << getTargetMMOFlagName(*TII, MachineMemOperand::MOTargetFlag2) - << "\" "; - if (getFlags() & MachineMemOperand::MOTargetFlag3) - OS << '"' << getTargetMMOFlagName(*TII, MachineMemOperand::MOTargetFlag3) - << "\" "; + if (TII) { + if (getFlags() & MachineMemOperand::MOTargetFlag1) + OS << '"' << getTargetMMOFlagName(*TII, MachineMemOperand::MOTargetFlag1) + << "\" "; + if (getFlags() & MachineMemOperand::MOTargetFlag2) + OS << '"' << getTargetMMOFlagName(*TII, MachineMemOperand::MOTargetFlag2) + << "\" "; + if (getFlags() & MachineMemOperand::MOTargetFlag3) + OS << '"' << getTargetMMOFlagName(*TII, MachineMemOperand::MOTargetFlag3) + << "\" "; + } else { + if (getFlags() & MachineMemOperand::MOTargetFlag1) + OS << "\"MOTargetFlag1\" "; + if (getFlags() & MachineMemOperand::MOTargetFlag2) + OS << "\"MOTargetFlag2\" "; + if (getFlags() & MachineMemOperand::MOTargetFlag3) + OS << "\"MOTargetFlag3\" "; + } assert((isLoad() || isStore()) && "machine memory operand must be a load or store (or both)"); |