diff options
author | Hans Wennborg <hans@hanshq.net> | 2017-12-08 05:19:12 +0000 |
---|---|---|
committer | Hans Wennborg <hans@hanshq.net> | 2017-12-08 05:19:12 +0000 |
commit | 5bb88e0f9e70e906b7400ac3b45d0941bef674d8 (patch) | |
tree | 3f980b906710edb71779aec7fc9093e436801674 /llvm/lib/CodeGen/MachineOperand.cpp | |
parent | 29477dc82e9f6e35a91210daa834c59d8216d308 (diff) | |
download | llvm-5bb88e0f9e70e906b7400ac3b45d0941bef674d8.zip llvm-5bb88e0f9e70e906b7400ac3b45d0941bef674d8.tar.gz llvm-5bb88e0f9e70e906b7400ac3b45d0941bef674d8.tar.bz2 |
Revert r320124 "Fold together the in-range and out-of-range portions of -Wtautological-compare."
This broke Chromium:
../../base/trace_event/trace_log.cc:1545:29: error: comparison of constant 64
with expression of type 'unsigned int' is always true
[-Werror,-Wtautological-constant-out-of-range-compare]
DCHECK(handle.event_index < TraceBufferChunk::kTraceBufferChunkSize);
~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The 'unsigned int' is really a 6-bit bitfield, which is why it's always
less than 63.
Did this use to fall under the "in-range" case before? I thought we
didn't use to warn when comparing against the boundaries of a type.
llvm-svn: 320133
Diffstat (limited to 'llvm/lib/CodeGen/MachineOperand.cpp')
0 files changed, 0 insertions, 0 deletions