diff options
| author | Nikita Popov <npopov@redhat.com> | 2023-12-04 09:24:13 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-12-04 09:24:13 +0100 |
| commit | 0cdacd5f492991362bfc8e252673aafdb9651322 (patch) | |
| tree | b0e30eb0ac9a69d33e8106f6d09bdcb6e8461699 /llvm/lib/CodeGen/MachineOperand.cpp | |
| parent | b96bae2887f276345f9c0ea9974703e8dd3b5ddf (diff) | |
| download | llvm-0cdacd5f492991362bfc8e252673aafdb9651322.zip llvm-0cdacd5f492991362bfc8e252673aafdb9651322.tar.gz llvm-0cdacd5f492991362bfc8e252673aafdb9651322.tar.bz2 | |
[DomTree] Fix root attachment in runDFS() (#73148)
Currently, runDFS() only sets the Parent of the DFS root if it is
already in the NodeToInfo map. This doesn't matter if we're running DFS
on the DT root, which doesn't have a parent anyway. However, when
running on PDT roots, this means we end up keeping the parent at 0,
rather than setting it to 1 for the virtual PDT root. Because the
virtual root (nullptr) has the same value as the dummy value in
NumToNode (nullptr) this happens to work out by accident right now.
I believe we should always be setting the parent in runDFS(), and adjust
AttachToNum in doFullDFSWalk() to be 1 (the virtual root) for PDTs.
Diffstat (limited to 'llvm/lib/CodeGen/MachineOperand.cpp')
0 files changed, 0 insertions, 0 deletions