diff options
| author | Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> | 2020-01-18 22:10:46 +0100 |
|---|---|---|
| committer | Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> | 2020-01-18 22:10:46 +0100 |
| commit | 002ec79f979b9da9dedafe7ea036e00c90a9fbb7 (patch) | |
| tree | 7f6a9780d5e5da7b9a81331d0983371dd039b440 /llvm/lib/CodeGen/MachineModuleInfo.cpp | |
| parent | e3d92b7442eaf3319f84bc060492df5b7ac3e9a1 (diff) | |
| download | llvm-002ec79f979b9da9dedafe7ea036e00c90a9fbb7.zip llvm-002ec79f979b9da9dedafe7ea036e00c90a9fbb7.tar.gz llvm-002ec79f979b9da9dedafe7ea036e00c90a9fbb7.tar.bz2 | |
[mlir] NFC: Rename index_t to index_type
mlir currently fails to build on Solaris:
/vol/llvm/src/llvm-project/dist/mlir/lib/Conversion/VectorToLoops/ConvertVectorToLoops.cpp:78:20: error: reference to 'index_t' is ambiguous
IndexHandle zero(index_t(0)), one(index_t(1));
^
/usr/include/sys/types.h:103:16: note: candidate found by name lookup is 'index_t'
typedef short index_t;
^
/vol/llvm/src/llvm-project/dist/mlir/include/mlir/EDSC/Builders.h:27:8: note: candidate found by name lookup is 'mlir::edsc::index_t'
struct index_t {
^
and many more.
Given that POSIX reserves all identifiers ending in `_t` 2.2.2 The Name Space <https://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html>, it seems
quite unwise to use such identifiers in user code, even more so without a distinguished
prefix.
The following patch fixes this by renaming `index_t` to `index_type`.
cases.
Tested on `amd64-pc-solaris2.11` and `sparcv9-sun-solaris2.11`.
Differential Revision: https://reviews.llvm.org/D72619
Diffstat (limited to 'llvm/lib/CodeGen/MachineModuleInfo.cpp')
0 files changed, 0 insertions, 0 deletions