diff options
| author | Nick Desaulniers <ndesaulniers@google.com> | 2023-08-31 08:39:52 -0700 |
|---|---|---|
| committer | Nick Desaulniers <ndesaulniers@google.com> | 2023-08-31 08:54:51 -0700 |
| commit | 2fad6e69851ecbaf01553cd5790e4575290bf0a9 (patch) | |
| tree | 44ab94caa8c08bf5d4af5fd5fdf97f6c571f600f /llvm/lib/CodeGen/MachineInstr.cpp | |
| parent | cdd5b1629abedd5e9d6ee280e592baa3c1dd1542 (diff) | |
| download | llvm-2fad6e69851ecbaf01553cd5790e4575290bf0a9.zip llvm-2fad6e69851ecbaf01553cd5790e4575290bf0a9.tar.gz llvm-2fad6e69851ecbaf01553cd5790e4575290bf0a9.tar.bz2 | |
[InlineAsm] wrap Kind in enum class NFC
Should add some minor type safety to the use of this information, since
there's quite a bit of metadata being laundered through an `unsigned`.
I'm looking to potentially add more bitfields to that `unsigned`, but I
find InlineAsm's big ol' bag of enum values and usage of `unsigned`
confusing, type-unsafe, and un-ergonomic. These can probably be better
abstracted.
I think the lack of static_cast outside of InlineAsm indicates the prior
code smell fixed here.
Reviewed By: qcolombet
Differential Revision: https://reviews.llvm.org/D159242
Diffstat (limited to 'llvm/lib/CodeGen/MachineInstr.cpp')
| -rw-r--r-- | llvm/lib/CodeGen/MachineInstr.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/llvm/lib/CodeGen/MachineInstr.cpp b/llvm/lib/CodeGen/MachineInstr.cpp index 13673fb..1c03ac1 100644 --- a/llvm/lib/CodeGen/MachineInstr.cpp +++ b/llvm/lib/CodeGen/MachineInstr.cpp @@ -924,14 +924,14 @@ MachineInstr::getRegClassConstraint(unsigned OpIdx, unsigned Flag = getOperand(FlagIdx).getImm(); unsigned RCID; - if ((InlineAsm::getKind(Flag) == InlineAsm::Kind_RegUse || - InlineAsm::getKind(Flag) == InlineAsm::Kind_RegDef || - InlineAsm::getKind(Flag) == InlineAsm::Kind_RegDefEarlyClobber) && + if ((InlineAsm::getKind(Flag) == InlineAsm::Kind::RegUse || + InlineAsm::getKind(Flag) == InlineAsm::Kind::RegDef || + InlineAsm::getKind(Flag) == InlineAsm::Kind::RegDefEarlyClobber) && InlineAsm::hasRegClassConstraint(Flag, RCID)) return TRI->getRegClass(RCID); // Assume that all registers in a memory operand are pointers. - if (InlineAsm::getKind(Flag) == InlineAsm::Kind_Mem) + if (InlineAsm::getKind(Flag) == InlineAsm::Kind::Mem) return TRI->getPointerRegClass(MF); return nullptr; |