diff options
| author | Guillaume Chatelet <gchatelet@google.com> | 2020-01-21 15:00:04 +0100 |
|---|---|---|
| committer | Guillaume Chatelet <gchatelet@google.com> | 2020-01-24 12:53:58 +0100 |
| commit | 805c157e8aeee24adec897bed42662733eb0d710 (patch) | |
| tree | 23f9e5adbcc7b67a96d72e13d2e2714ebdb00f2e /llvm/lib/CodeGen/MachineFrameInfo.cpp | |
| parent | 2ee218f3653fcfd135fc5087a698424f90a9a499 (diff) | |
| download | llvm-805c157e8aeee24adec897bed42662733eb0d710.zip llvm-805c157e8aeee24adec897bed42662733eb0d710.tar.gz llvm-805c157e8aeee24adec897bed42662733eb0d710.tar.bz2 | |
[Alignment][NFC] Deprecate Align::None()
Summary:
This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that `Align(1)` relies on the compiler understanding of `Log2_64` implementation to produce good code. One could use `Align()` as a replacement but I believe it is less clear that the alignment is one in that case.
Reviewers: xbolva00, courbet, bollu
Subscribers: arsenm, dylanmckay, sdardis, nemanjai, jvesely, nhaehnle, hiraditya, kbarton, jrtc27, atanasyan, jsji, Jim, kerbowa, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D73099
Diffstat (limited to 'llvm/lib/CodeGen/MachineFrameInfo.cpp')
| -rw-r--r-- | llvm/lib/CodeGen/MachineFrameInfo.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/lib/CodeGen/MachineFrameInfo.cpp b/llvm/lib/CodeGen/MachineFrameInfo.cpp index 22ab2c7..e5f35ae 100644 --- a/llvm/lib/CodeGen/MachineFrameInfo.cpp +++ b/llvm/lib/CodeGen/MachineFrameInfo.cpp @@ -89,7 +89,7 @@ int MachineFrameInfo::CreateFixedObject(uint64_t Size, int64_t SPOffset, // stack needs realignment, we can't assume that the stack will in fact be // aligned. Align Alignment = - commonAlignment(ForcedRealign ? Align::None() : StackAlignment, SPOffset); + commonAlignment(ForcedRealign ? Align(1) : StackAlignment, SPOffset); Alignment = clampStackAlignment(!StackRealignable, Alignment, StackAlignment); Objects.insert(Objects.begin(), StackObject(Size, Alignment, SPOffset, IsImmutable, @@ -102,7 +102,7 @@ int MachineFrameInfo::CreateFixedSpillStackObject(uint64_t Size, int64_t SPOffset, bool IsImmutable) { Align Alignment = - commonAlignment(ForcedRealign ? Align::None() : StackAlignment, SPOffset); + commonAlignment(ForcedRealign ? Align(1) : StackAlignment, SPOffset); Alignment = clampStackAlignment(!StackRealignable, Alignment, StackAlignment); Objects.insert(Objects.begin(), StackObject(Size, Alignment, SPOffset, IsImmutable, |