aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
diff options
context:
space:
mode:
authorFlorian Hahn <flo@fhahn.com>2023-12-23 15:53:48 +0100
committerGitHub <noreply@github.com>2023-12-23 15:53:48 +0100
commitfbcf8a8cbb2461730bfd0603b396842925a88ef2 (patch)
tree71c9b4e1cc1a03727c6fa14faf30a77ef32ca820 /llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
parented6dc6286264f0b6e94bb786a462d9975144ee7d (diff)
downloadllvm-fbcf8a8cbb2461730bfd0603b396842925a88ef2.zip
llvm-fbcf8a8cbb2461730bfd0603b396842925a88ef2.tar.gz
llvm-fbcf8a8cbb2461730bfd0603b396842925a88ef2.tar.bz2
[ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)
The constraint system used for ConstraintElimination assumes all varibles to be signed. This can cause missed optimization in the unsigned system, due to missing the information that all variables are unsigned (non-negative). Variables can be marked as non-negative by adding Var >= 0 for all variables. This is done for arguments on ConstraintInfo construction and after adding new variables. This handles cases like the ones outlined in https://discourse.llvm.org/t/why-does-llvm-not-perform-range-analysis-on-integer-values/74341 The original example shared above is now handled without this change, but adding another variable means that instcombine won't be able to simplify examples like https://godbolt.org/z/hTnra7zdY Adding the extra variables comes with a slight compile-time increase https://llvm-compile-time-tracker.com/compare.php?from=7568b36a2bc1a1e496ec29246966ffdfc3a8b87f&to=641a47f0acce7755e340447386013a2e086f03d9&stat=instructions:u stage1-O3 stage1-ReleaseThinLTO stage1-ReleaseLTO-g stage1-O0-g +0.04% +0.07% +0.05% +0.02% stage2-O3 stage2-O0-g stage2-clang +0.05% +0.05% +0.05% https://github.com/llvm/llvm-project/pull/76262
Diffstat (limited to 'llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp')
0 files changed, 0 insertions, 0 deletions