diff options
| author | Balazs Benics <balazs.benics@sigmatechnology.se> | 2021-06-29 16:35:07 +0200 |
|---|---|---|
| committer | Balazs Benics <balazs.benics@sigmatechnology.se> | 2021-06-29 16:35:07 +0200 |
| commit | 3dae01911b6902f00e80eb7ebdc2f55bb28f173e (patch) | |
| tree | 875a6a25997318fad17bfd940ededa1426b6419d /llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp | |
| parent | 9de63367d8a7ab9e2588de4eae5a5df6a1abd90f (diff) | |
| download | llvm-3dae01911b6902f00e80eb7ebdc2f55bb28f173e.zip llvm-3dae01911b6902f00e80eb7ebdc2f55bb28f173e.tar.gz llvm-3dae01911b6902f00e80eb7ebdc2f55bb28f173e.tar.bz2 | |
[analyzer] Make CheckerManager::hasPathSensitiveCheckers() complete again
It turns out that the CheckerManager::hasPathSensitiveCheckers() missed
checking for the BeginFunctionCheckers.
It seems like other callbacks are also missing:
- ObjCMessageNilCheckers
- BeginFunctionCheckers
- NewAllocatorCheckers
- PointerEscapeCheckers
- EndOfTranslationUnitCheckers
In this patch, I wanted to use a fold-expression, but until C++17
arrives we are left with the old-school method.
When I tried to write a unittest I observed an interesting behavior. I
subscribed only to the BeginFunction event, it was not fired.
However, when I also defined the PreCall with an empty handler, suddenly
both fired.
I could add this test demonstrating the issue, but I don't think it
would serve much value in a long run. I don't expect regressions for
this.
However, I think it would be great to enforce the completeness of this
list in a runtime check.
I could not come up with a solution for this though.
PS: Thank you @Szelethus for helping me debugging this.
Differential Revision: https://reviews.llvm.org/D105101
Reviewed by: vsavchenko
Diffstat (limited to 'llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp')
0 files changed, 0 insertions, 0 deletions