diff options
| author | Kevin P. Neal <kevin.neal@sas.com> | 2024-04-17 08:34:25 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-17 08:34:25 -0400 |
| commit | 79726ef5d20f3bf6510b67d7dd3378b8a41db768 (patch) | |
| tree | 5de6283a32ad008923d9bbc32c4ab45d15d30007 /llvm/lib/CodeGen/ExpandVectorPredication.cpp | |
| parent | 915c84b1480bb3c6d2e44ca83822d2c2304b763a (diff) | |
| download | llvm-79726ef5d20f3bf6510b67d7dd3378b8a41db768.zip llvm-79726ef5d20f3bf6510b67d7dd3378b8a41db768.tar.gz llvm-79726ef5d20f3bf6510b67d7dd3378b8a41db768.tar.bz2 | |
[VP] Correct lowering of predicated fma and faddmul to avoid strictfp. (#85272)
Correct missing cases in a switch that result in @llvm.vp.fma.v4f32
getting lowered to a constrained fma intrinsic. Vector predicated
lowering to contrained intrinsics is not supported currently, and
there's no consensus on the path forward. We certainly shouldn't be
introducing constrained intrinsics into a function that isn't strictfp.
Problem found with D146845.
Diffstat (limited to 'llvm/lib/CodeGen/ExpandVectorPredication.cpp')
| -rw-r--r-- | llvm/lib/CodeGen/ExpandVectorPredication.cpp | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/llvm/lib/CodeGen/ExpandVectorPredication.cpp b/llvm/lib/CodeGen/ExpandVectorPredication.cpp index 0fe4cfe..8e623c8 100644 --- a/llvm/lib/CodeGen/ExpandVectorPredication.cpp +++ b/llvm/lib/CodeGen/ExpandVectorPredication.cpp @@ -340,6 +340,8 @@ Value *CachingVPExpander::expandPredicationToFPCall( replaceOperation(*NewOp, VPI); return NewOp; } + case Intrinsic::fma: + case Intrinsic::fmuladd: case Intrinsic::experimental_constrained_fma: case Intrinsic::experimental_constrained_fmuladd: { Value *Op0 = VPI.getOperand(0); @@ -347,8 +349,12 @@ Value *CachingVPExpander::expandPredicationToFPCall( Value *Op2 = VPI.getOperand(2); Function *Fn = Intrinsic::getDeclaration( VPI.getModule(), UnpredicatedIntrinsicID, {VPI.getType()}); - Value *NewOp = - Builder.CreateConstrainedFPCall(Fn, {Op0, Op1, Op2}, VPI.getName()); + Value *NewOp; + if (Intrinsic::isConstrainedFPIntrinsic(UnpredicatedIntrinsicID)) + NewOp = + Builder.CreateConstrainedFPCall(Fn, {Op0, Op1, Op2}, VPI.getName()); + else + NewOp = Builder.CreateCall(Fn, {Op0, Op1, Op2}, VPI.getName()); replaceOperation(*NewOp, VPI); return NewOp; } @@ -731,6 +737,8 @@ Value *CachingVPExpander::expandPredication(VPIntrinsic &VPI) { case Intrinsic::vp_minnum: case Intrinsic::vp_maximum: case Intrinsic::vp_minimum: + case Intrinsic::vp_fma: + case Intrinsic::vp_fmuladd: return expandPredicationToFPCall(Builder, VPI, VPI.getFunctionalIntrinsicID().value()); case Intrinsic::vp_load: |