aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/CodeGen/CodePlacementOpt.cpp
diff options
context:
space:
mode:
authorBob Wilson <bob.wilson@apple.com>2009-05-07 23:47:03 +0000
committerBob Wilson <bob.wilson@apple.com>2009-05-07 23:47:03 +0000
commite20be4183c3a87a1115917f673c503e2e0e462ab (patch)
tree369c66635b86a3033365d6985f74b8fa74705c9c /llvm/lib/CodeGen/CodePlacementOpt.cpp
parent7ce29a18e1f5d5cdd6955aafbe3354e02bf53122 (diff)
downloadllvm-e20be4183c3a87a1115917f673c503e2e0e462ab.zip
llvm-e20be4183c3a87a1115917f673c503e2e0e462ab.tar.gz
llvm-e20be4183c3a87a1115917f673c503e2e0e462ab.tar.bz2
Fix pr4100. Do not remove no-op copies when they are dead. The register
scavenger gets confused about register liveness if it doesn't see them. I'm not thrilled with this solution, but it only comes up when there are dead copies in the code, which is something that hopefully doesn't happen much. Here is what happens in pr4100: As shown in the following excerpt from the debug output of llc, the source of a move gets reloaded from the stack, inserting a new load instruction before the move. Since that source operand is a kill, the physical register is free to be reused for the destination of the move. The move ends up being a no-op, copying R3 to R3, so it is deleted. But, it leaves behind the load to reload %reg1028 into R3, and that load is not updated to show that it's destination operand (R3) is dead. The scavenger gets confused by that load because it thinks that R3 is live. Starting RegAlloc of: %reg1025<def,dead> = MOVr %reg1028<kill>, 14, %reg0, %reg0 Regs have values: Reloading %reg1028 into R3 Last use of R3[%reg1028], removing it from live set Assigning R3 to %reg1025 Register R3 [%reg1025] is never used, removing it from live set Alternative solutions might be either marking the load as dead, or zapping the load along with the no-op copy. I couldn't see an easy way to do either of those, though. llvm-svn: 71196
Diffstat (limited to 'llvm/lib/CodeGen/CodePlacementOpt.cpp')
0 files changed, 0 insertions, 0 deletions