diff options
author | Stephen Tozer <stephen.tozer@sony.com> | 2024-03-14 12:19:15 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-03-14 12:19:15 +0000 |
commit | 2e865353ed6baa35609e94bf5de9f2061df6eacf (patch) | |
tree | 25ba906fafce3dae1ebe5caf1cae4bfb3d9ddb6c /llvm/lib/CodeGen/CodeGenPrepare.cpp | |
parent | 5f774619eac5db73398225a4c924a9c1d437fb40 (diff) | |
download | llvm-2e865353ed6baa35609e94bf5de9f2061df6eacf.zip llvm-2e865353ed6baa35609e94bf5de9f2061df6eacf.tar.gz llvm-2e865353ed6baa35609e94bf5de9f2061df6eacf.tar.bz2 |
[RemoveDIs][NFC] Move DPValue::filter -> filterDbgVars (#85208)
This patch changes DPValue::filter to be a non-member method
filterDbgVars. There are two reasons for this: firstly, the name of
DPValue is about to change to DbgVariableRecord, which will result in
every `for` loop that uses DPValue::filter to require a line break. This
is a small thing, but it makes the rename patch more difficult to
review, and is just generally more awkward for what is a fairly common
loop. Secondly, the intent is to later break up the DPValue class into
subclasses, at which point it would be better to have a non-member
function that allows template arguments for the cases we want to filter
with greater specificity.
Diffstat (limited to 'llvm/lib/CodeGen/CodeGenPrepare.cpp')
-rw-r--r-- | llvm/lib/CodeGen/CodeGenPrepare.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/lib/CodeGen/CodeGenPrepare.cpp b/llvm/lib/CodeGen/CodeGenPrepare.cpp index 055e275..bece70a 100644 --- a/llvm/lib/CodeGen/CodeGenPrepare.cpp +++ b/llvm/lib/CodeGen/CodeGenPrepare.cpp @@ -8506,7 +8506,7 @@ bool CodeGenPrepare::fixupDbgValue(Instruction *I) { bool CodeGenPrepare::fixupDPValuesOnInst(Instruction &I) { bool AnyChange = false; - for (DPValue &DPV : DPValue::filter(I.getDbgRecordRange())) + for (DPValue &DPV : filterDbgVars(I.getDbgRecordRange())) AnyChange |= fixupDPValue(DPV); return AnyChange; } @@ -8620,7 +8620,7 @@ bool CodeGenPrepare::placeDbgValues(Function &F) { // If this isn't a dbg.value, process any attached DPValue records // attached to this instruction. for (DPValue &DPV : llvm::make_early_inc_range( - DPValue::filter(Insn.getDbgRecordRange()))) { + filterDbgVars(Insn.getDbgRecordRange()))) { if (DPV.Type != DPValue::LocationType::Value) continue; DbgProcessor(&DPV, &Insn); |