aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
diff options
context:
space:
mode:
authorMartin Storsjö <martin@martin.st>2021-12-21 13:14:28 +0000
committerMartin Storsjö <martin@martin.st>2021-12-22 00:43:29 +0200
commitd67b25e7f6d9eb320382933ff650de97161f801e (patch)
tree15e111bd7a357b03fa138df55426192467ec34d6 /llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
parentf68e89044a2ee14babd1af8fc406c9bab080992a (diff)
downloadllvm-d67b25e7f6d9eb320382933ff650de97161f801e.zip
llvm-d67b25e7f6d9eb320382933ff650de97161f801e.tar.gz
llvm-d67b25e7f6d9eb320382933ff650de97161f801e.tar.bz2
[libcxx] [test] Extend test for bash for executor-has-no-bash
If %{exec} sets "--env PATH=single-dir", the directory containing bash and related shell utils is omitted from the path, which means that most shell scripts would fail. (Setting PATH is needed for DLL builds on Windows; PATH fills the same role as e.g. LD_LIBRARY_PATH on Linux.) This condition is missed in the current test, because the executor run.py first resolves the executable to run using the original path, then invokes that executable with an environment with a restricted path. Thus the executor is able to run bash, but that bash is then unable to run further shell commands (other than bash builtins). Extend the test from "bash --version" to "bash -c 'bash --version'". This correctly identifies the executor-has-no-bash condition in the current Windows CI configs, allowing removing 6 cases of LIBCXX-WINDOWS-FIXME. Another longterm fix would be to extend run.py with an option like "--env-prepend PATH=dir", to allow keeping the current path while adding a directory to it. Differential Revision: https://reviews.llvm.org/D116117
Diffstat (limited to 'llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp')
0 files changed, 0 insertions, 0 deletions