diff options
| author | Chandler Carruth <chandlerc@gmail.com> | 2016-12-16 04:05:22 +0000 |
|---|---|---|
| committer | Chandler Carruth <chandlerc@gmail.com> | 2016-12-16 04:05:22 +0000 |
| commit | 4154062b6902862e987fb5b62293e0ff5915cbe9 (patch) | |
| tree | 08ebe21e281be7ac6b0e73ff43da0c80f4b81d31 /llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp | |
| parent | c1ded7dcef3fcb94fe95fd0105b220b54c515158 (diff) | |
| download | llvm-4154062b6902862e987fb5b62293e0ff5915cbe9.zip llvm-4154062b6902862e987fb5b62293e0ff5915cbe9.tar.gz llvm-4154062b6902862e987fb5b62293e0ff5915cbe9.tar.bz2 | |
Revert patch series introducing the DAG combine to match a load-by-bytes
idiom.
r289538: Match load by bytes idiom and fold it into a single load
r289540: Fix a buildbot failure introduced by r289538
r289545: Use more detailed assertion messages in the code ...
r289646: Add a couple of assertions to the load combine code ...
This DAG combine has a bad crash in it that is quite hard to trigger
sadly -- it relies on sneaking code with UB through the SDAG build and
into this particular combine. I've responded to the original commit with
a test case that reproduces it.
However, the code also has other problems that will require substantial
changes to address and so I'm going ahead and reverting it for now. This
should unblock us and perhaps others that are hitting the crash in the
wild and will let a fresh patch with updated approach come in cleanly
afterward.
Sorry for any trouble or disruption!
llvm-svn: 289916
Diffstat (limited to 'llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp')
0 files changed, 0 insertions, 0 deletions