diff options
author | Nick Desaulniers <ndesaulniers@google.com> | 2020-03-12 15:13:55 -0700 |
---|---|---|
committer | Nick Desaulniers <ndesaulniers@google.com> | 2020-03-12 15:13:59 -0700 |
commit | 246398ece7115b57a02dbe7876d86ae8e72406ef (patch) | |
tree | b54b63c2512e390ddaedf52892778f6f17b3a2d5 /llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp | |
parent | a73528649c85dabbe22fbd27ee6e1d65bbabad14 (diff) | |
download | llvm-246398ece7115b57a02dbe7876d86ae8e72406ef.zip llvm-246398ece7115b57a02dbe7876d86ae8e72406ef.tar.gz llvm-246398ece7115b57a02dbe7876d86ae8e72406ef.tar.bz2 |
[clang][Parse] properly parse asm-qualifiers, asm inline
Summary:
The parsing of GNU C extended asm statements was a little brittle and
had a few issues:
- It was using Parse::ParseTypeQualifierListOpt to parse the `volatile`
qualifier. That parser is really meant for TypeQualifiers; an asm
statement doesn't really have a type qualifier. This is still maybe
nice to have, but not necessary. We now can check for the `volatile`
token by properly expanding the grammer, rather than abusing
Parse::ParseTypeQualifierListOpt.
- The parsing of `goto` was position dependent, so `asm goto volatile`
wouldn't parse. The qualifiers should be position independent to one
another. Now they are.
- We would warn on duplicate `volatile`, but the parse error for
duplicate `goto` was a generic parse error and wasn't clear.
- We need to add support for the recent GNU C extension `asm inline`.
Adding support to the parser with the above issues highlighted the
need for this refactoring.
Link: https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html
Reviewers: aaron.ballman
Reviewed By: aaron.ballman
Subscribers: aheejin, jfb, nathanchance, cfe-commits, echristo, efriedma, rsmith, chandlerc, craig.topper, erichkeane, jyu2, void, srhines
Tags: #clang
Differential Revision: https://reviews.llvm.org/D75563
Diffstat (limited to 'llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp')
0 files changed, 0 insertions, 0 deletions