diff options
| author | Michael Buch <michaelbuch12@gmail.com> | 2025-10-31 10:18:13 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-10-31 10:18:13 +0000 |
| commit | b81a9927974b5b2941114b1ca6ceedb61875d988 (patch) | |
| tree | 4c593b5fbff1ec915544c8c2db59c588695260c8 /llvm/lib/Bitcode/Writer/BitcodeWriterPass.cpp | |
| parent | ef2a05d869a72dc3648ac6090036220f3cb9bc53 (diff) | |
| download | llvm-b81a9927974b5b2941114b1ca6ceedb61875d988.zip llvm-b81a9927974b5b2941114b1ca6ceedb61875d988.tar.gz llvm-b81a9927974b5b2941114b1ca6ceedb61875d988.tar.bz2 | |
[lldb][TypeSystem] Remove count parameter from TypeSystem::IsFloatingPointType (#165707)
Similar motivation to https://github.com/llvm/llvm-project/pull/165702.
It was unused in all callsites and inconsistent with other APIs like
`IsIntegerType` (which doesn't take a `count` parameter).
If we ever need a "how many elements does this type represent", we can
implement one with a new TypeSystem API that does exactly that.
Some callsites checked for `count == 1` previously, but I suspect what
they intended to do is check for whether it's a vector type or complex
type, before reading the FP register. I'm somewhat confident that's the
case because the `TypeSystemClang::GetTypeInfo` currently incorrectly
sets the integer and floating point bits for complex and vector types
(will fix separately). But some architectures might choose to pass
single-element vectors in scalar registers. I should probably changes
these to check the vector element size.
All the `count == 2 && is_complex` were redundant because `count == 2`
iff `is_complex == true`. So I just removed the count check there.
Diffstat (limited to 'llvm/lib/Bitcode/Writer/BitcodeWriterPass.cpp')
0 files changed, 0 insertions, 0 deletions
