diff options
| author | Georgii Rymar <grimar@accesssoftek.com> | 2020-02-12 16:12:09 +0300 |
|---|---|---|
| committer | Georgii Rymar <grimar@accesssoftek.com> | 2020-02-18 14:36:17 +0300 |
| commit | b87a0f7416f1a657d808690295b44669849e7bfc (patch) | |
| tree | 1046e1663e8566efb5689ca8ca23ae38f47e71ce /llvm/lib/Bitcode/Writer/BitcodeWriter.cpp | |
| parent | cc7a197f9f1039e36625249199aa652f84506802 (diff) | |
| download | llvm-b87a0f7416f1a657d808690295b44669849e7bfc.zip llvm-b87a0f7416f1a657d808690295b44669849e7bfc.tar.gz llvm-b87a0f7416f1a657d808690295b44669849e7bfc.tar.bz2 | |
[llvm-readobj] - Report a warning when an unexpected DT_SYMENT tag value is met.
There was a short discussion about this:
https://reviews.llvm.org/D73484#inline-676942
To summarize:
It is a bit unclear to me why the `DT_SYMENT` tag exist.
LLD has the code that does:
"addInt(DT_SYMENT, sizeof(Elf_Sym));" and I guess other linkers has the same logic.
It is unclear why it can be possible to have other values rather than values of
a size of platform symbol. Seems it is not possible, and atm for me it looks that
this tag should not be used. This patch starts reporting the warning when the
value it contains differs from a symbol size for a 32/64 bit platform for safety.
It keeps the rest of the logic we have unchanged. Before this patch we did not handle
the tag at all.
Differential review: https://reviews.llvm.org/D74479
Diffstat (limited to 'llvm/lib/Bitcode/Writer/BitcodeWriter.cpp')
0 files changed, 0 insertions, 0 deletions