diff options
| author | Eli Friedman <efriedma@quicinc.com> | 2020-05-18 20:38:13 -0700 |
|---|---|---|
| committer | Eli Friedman <efriedma@quicinc.com> | 2020-06-23 19:13:42 -0700 |
| commit | a2caa3b61497b6be8c8b77823d0fd62b4be1f177 (patch) | |
| tree | 9da9e17f80ffd8bb60a06eb2d7932c8a91611932 /llvm/lib/Bitcode/Writer/BitcodeWriter.cpp | |
| parent | f8bd6a75edac7560deb5fdcb31041b454dd9d7e0 (diff) | |
| download | llvm-a2caa3b61497b6be8c8b77823d0fd62b4be1f177.zip llvm-a2caa3b61497b6be8c8b77823d0fd62b4be1f177.tar.gz llvm-a2caa3b61497b6be8c8b77823d0fd62b4be1f177.tar.bz2 | |
Remove GlobalValue::getAlignment().
This function is deceptive at best: it doesn't return what you'd expect.
If you have an arbitrary GlobalValue and you want to determine the
alignment of that pointer, Value::getPointerAlignment() returns the
correct value. If you want the actual declared alignment of a function
or variable, GlobalObject::getAlignment() returns that.
This patch switches all the users of GlobalValue::getAlignment to an
appropriate alternative.
Differential Revision: https://reviews.llvm.org/D80368
Diffstat (limited to 'llvm/lib/Bitcode/Writer/BitcodeWriter.cpp')
| -rw-r--r-- | llvm/lib/Bitcode/Writer/BitcodeWriter.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp b/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp index e9cf5af..a23f39b 100644 --- a/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp +++ b/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp @@ -1179,7 +1179,7 @@ void ModuleBitcodeWriter::writeModuleInfo() { std::map<std::string, unsigned> GCMap; unsigned MaxAlignment = 0; unsigned MaxGlobalType = 0; - for (const GlobalValue &GV : M.globals()) { + for (const GlobalVariable &GV : M.globals()) { MaxAlignment = std::max(MaxAlignment, GV.getAlignment()); MaxGlobalType = std::max(MaxGlobalType, VE.getTypeID(GV.getValueType())); if (GV.hasSection()) { |