diff options
| author | Marcell Leleszi <59964679+mleleszi@users.noreply.github.com> | 2025-11-06 21:55:16 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-11-06 12:55:16 -0800 |
| commit | 6adf99338832966dcf3477e112b158cd588ac584 (patch) | |
| tree | 337fecca37b904ec886356a77278fc536ded0d21 /llvm/lib/Bitcode/Writer/BitcodeWriter.cpp | |
| parent | aa1b1dc3914df84581e92fa75e6b8ff7007e0295 (diff) | |
| download | llvm-6adf99338832966dcf3477e112b158cd588ac584.zip llvm-6adf99338832966dcf3477e112b158cd588ac584.tar.gz llvm-6adf99338832966dcf3477e112b158cd588ac584.tar.bz2 | |
[libc] Disable overflow test in strfromtest on riscv32 (#166719)
Looks like https://github.com/llvm/llvm-project/pull/166517 is breaking
libc-riscv32-qemu-yocto-fullbuild-dbg build due to failing overflow test
for strfrom.
https://lab.llvm.org/buildbot/#/changes/58668
```
int result = func(buff, sizeof(buff), "%.2147483647f", 1.0f);
EXPECT_LT(result, 0);
ASSERT_ERRNO_FAILURE();
```
```
[ RUN ] LlvmLibcStrfromdTest.CharsWrittenOverflow
/home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/llvm-project/libc/test/src/stdlib/StrfromTest.h:493: FAILURE
Expected: result
Which is: 0
To be less than: 0
Which is: 0
/home/libcrv32buildbot/bbroot/libc-riscv32-qemu-yocto-fullbuild-dbg/llvm-project/libc/test/src/stdlib/StrfromTest.h:494: FAILURE
Expected: 0
Which is: 0
To be not equal to: static_cast<int>(libc_errno)
Which is: 0
[ FAILED ] LlvmLibcStrfromdTest.CharsWrittenOverflow
Ran 8 tests. PASS: 7 FAIL: 1
```
At first glance it seem like there is some kind of overflow in
internal::strfromfloat_convert on 32bit archs because the other overflow
test case is passing for snprintf. Interestingly, it passes on all other
buildbots, including libc-arm32-qemu-debian-dbg.
This issue likely wasn't introduced by
https://github.com/llvm/llvm-project/pull/166517 and was probably
already present, so I'm not reverting the change just disabling the test
case on riscv32 until I can debug properly.
Diffstat (limited to 'llvm/lib/Bitcode/Writer/BitcodeWriter.cpp')
0 files changed, 0 insertions, 0 deletions
