diff options
| author | serge-sans-paille <sguelton@redhat.com> | 2020-02-24 17:21:32 +0100 |
|---|---|---|
| committer | serge-sans-paille <sguelton@redhat.com> | 2020-03-02 10:02:25 +0100 |
| commit | 5a1958f2673f8c771e406a7e309e160b432c9a79 (patch) | |
| tree | ce16cea4a7f2686afb84fbb6fa12b79d9be7398f /llvm/lib/Bitcode/Writer/BitcodeWriter.cpp | |
| parent | c443b610bf3682eb32949b552b8c6908a8d96267 (diff) | |
| download | llvm-5a1958f2673f8c771e406a7e309e160b432c9a79.zip llvm-5a1958f2673f8c771e406a7e309e160b432c9a79.tar.gz llvm-5a1958f2673f8c771e406a7e309e160b432c9a79.tar.bz2 | |
Syndicate, test and fix base64 implementation
Move Base64 implementation from clangd/SemanticHighlighting to
llvm/Support/Base64, fix its implementation and provide a decent test suite.
Previous implementation code was using + operator instead of | to combine some
results, which is a problem when shifting signed values. (0xFF << 16) is
implicitly converted to a (signed) int, and thus results in 0xffff0000, which is
negative. Combining negative numbers with a + in that context is not what we
want to do.
This fixes https://github.com/llvm/llvm-project/issues/149.
Differential Revision: https://reviews.llvm.org/D75057
Diffstat (limited to 'llvm/lib/Bitcode/Writer/BitcodeWriter.cpp')
0 files changed, 0 insertions, 0 deletions