aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
diff options
context:
space:
mode:
authorAdam Czachorowski <adamcz@google.com>2021-10-06 18:50:13 +0200
committerAdam Czachorowski <adamcz@google.com>2021-11-18 15:50:47 +0100
commit55a79318c60d8a39329195f43bf43b89da9a638e (patch)
tree18067be19c6661789c8637099e1dce949aa553fb /llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
parentb2ad420a786a4148893b0c5a2a56aeb4810a6fc1 (diff)
downloadllvm-55a79318c60d8a39329195f43bf43b89da9a638e.zip
llvm-55a79318c60d8a39329195f43bf43b89da9a638e.tar.gz
llvm-55a79318c60d8a39329195f43bf43b89da9a638e.tar.bz2
[clang][clangd] Improve signature help for variadic functions.
This covers both C-style variadic functions and template variadic w/ parameter packs. Previously we would return no signatures when working with template variadic functions once activeParameter reached the position of the parameter pack (except when it was the only param, then we'd still show it when no arguments were given). With this commit, we now show signathure help correctly. Additionally, this commit fixes the activeParameter value in LSP output of clangd in the presence of variadic functions (both kinds). LSP does not allow the activeParamter to be higher than the number of parameters in the active signature. With "..." or parameter pack being just one argument, for all but first argument passed to "..." we'd report incorrect activeParameter value. Clients such as VSCode would then treat it as 0, as suggested in the spec) and highlight the wrong parameter. In the future, we should add support for per-signature activeParamter value, which exists in LSP since 3.16.0. This is not part of this commit. Differential Revision: https://reviews.llvm.org/D111318
Diffstat (limited to 'llvm/lib/Bitcode/Writer/BitcodeWriter.cpp')
0 files changed, 0 insertions, 0 deletions