diff options
| author | Sanjay Patel <spatel@rotateright.com> | 2018-01-24 15:20:37 +0000 |
|---|---|---|
| committer | Sanjay Patel <spatel@rotateright.com> | 2018-01-24 15:20:37 +0000 |
| commit | 1d91ec34b2d50ec0cdbe63a9cfee2c2ae568e8b9 (patch) | |
| tree | 3dc3f0c9581fa442741b5975b833f302c1dcf73d /llvm/lib/Bitcode/Writer/BitcodeWriter.cpp | |
| parent | b2ac9942b2e5fe3542d2e6c0ce1d7a902a941618 (diff) | |
| download | llvm-1d91ec34b2d50ec0cdbe63a9cfee2c2ae568e8b9.zip llvm-1d91ec34b2d50ec0cdbe63a9cfee2c2ae568e8b9.tar.gz llvm-1d91ec34b2d50ec0cdbe63a9cfee2c2ae568e8b9.tar.bz2 | |
[ValueTracking] add recursion depth param to matchSelectPattern
We're getting bug reports:
https://bugs.llvm.org/show_bug.cgi?id=35807
https://bugs.llvm.org/show_bug.cgi?id=35840
https://bugs.llvm.org/show_bug.cgi?id=36045
...where we blow up the stack in value tracking because other passes are sending
in selects that have an operand that is itself the select.
We don't currently have a reliable way to avoid analyzing dead code that may take
non-standard forms, so bail out when things go too far.
This mimics the recursion depth limitations in other parts of value tracking.
Unfortunately, this pushes the underlying problems for other passes (jump-threading,
simplifycfg, correlated-propagation) into hiding. If someone wants to uncover those
again, the first draft of this patch on Phab would do that (it would assert rather
than bail out).
Differential Revision: https://reviews.llvm.org/D42442
llvm-svn: 323331
Diffstat (limited to 'llvm/lib/Bitcode/Writer/BitcodeWriter.cpp')
0 files changed, 0 insertions, 0 deletions