diff options
| author | Jay Foad <jay.foad@amd.com> | 2021-09-22 12:14:18 +0100 |
|---|---|---|
| committer | Jay Foad <jay.foad@amd.com> | 2021-09-24 11:44:49 +0100 |
| commit | 7863cc6c1c9e714de666f7df84fe9ef6ea7bb06c (patch) | |
| tree | 9eca1cdb48c94b37a4a272744ffe8186b61401ac /llvm/lib/Bitcode/Writer/BitWriter.cpp | |
| parent | 9c30beaeb228b63447793235570fc207831dd885 (diff) | |
| download | llvm-7863cc6c1c9e714de666f7df84fe9ef6ea7bb06c.zip llvm-7863cc6c1c9e714de666f7df84fe9ef6ea7bb06c.tar.gz llvm-7863cc6c1c9e714de666f7df84fe9ef6ea7bb06c.tar.bz2 | |
[LiveIntervals] Fix repairOldRegInRange for simple def cases
The fix applied in D23303 "LiveIntervalAnalysis: fix a crash in repairOldRegInRange"
was over-zealous. It would bail out when the end of the range to be
repaired was in the middle of the first segment of the live range of
Reg, which was always the case when the range contained a single def of
Reg.
This patch fixes it as suggested by Matthias Braun in post-commit review
on the original patch, and tests it by adding -early-live-intervals to
a selection of existing lit tests that now pass.
(Note that D23303 was originally applied to fix a crash in
SILoadStoreOptimizer, but that is now moot since D23814 updated
SILoadStoreOptimizer to run before scheduling so it no longer has to
update live intervals.)
Differential Revision: https://reviews.llvm.org/D110238
Unrevert with some changes to the tests:
- Add -verify-machineinstrs to check for remaining problems in live
interval support in TwoAddressInstructionPass.
- Drop test/CodeGen/AMDGPU/extract-load-i1.ll since it suffers from
some of those remaining problems.
Diffstat (limited to 'llvm/lib/Bitcode/Writer/BitWriter.cpp')
0 files changed, 0 insertions, 0 deletions