diff options
| author | Daniil Kovalev <dkovalev@accesssoftek.com> | 2024-03-02 13:09:47 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-03-02 13:09:47 +0300 |
| commit | b14220e075fe47f4d61632e80a6d0a4a955a7c97 (patch) | |
| tree | c3d9fba7c1ce65ac334aed032fe661abb1ae8723 /llvm/lib/Bitcode/Reader/MetadataLoader.cpp | |
| parent | 597f9761c3a5ba278fa930d2fac13f156287d505 (diff) | |
| download | llvm-b14220e075fe47f4d61632e80a6d0a4a955a7c97.zip llvm-b14220e075fe47f4d61632e80a6d0a4a955a7c97.tar.gz llvm-b14220e075fe47f4d61632e80a6d0a4a955a7c97.tar.bz2 | |
[lldb][X86] Fix setting target features in ClangExpressionParser (#82364)
Currently, for x86 and x86_64 triples, "+sse" and "+sse2" are appended
to `Features` vector of `TargetOptions` unconditionally. This vector is
later reset in `TargetInfo::CreateTargetInfo` and filled using info from
`FeaturesAsWritten` vector, so previous modifications of the `Features`
vector have no effect. For x86_64 triple, we append "sse2"
unconditionally in `X86TargetInfo::initFeatureMap`, so despite the
`Features` vector reset, we still have the desired sse features enabled.
The corresponding code in `X86TargetInfo::initFeatureMap` is marked as
FIXME, so we should not probably rely on it and should set desired
features properly in `ClangExpressionParser`.
This patch changes the vector the features are appended to from
`Features` to `FeaturesAsWritten`. It's not reset later and is used to
compute resulting `Features` vector.
Diffstat (limited to 'llvm/lib/Bitcode/Reader/MetadataLoader.cpp')
0 files changed, 0 insertions, 0 deletions