diff options
author | George Burgess IV <george.burgess.iv@gmail.com> | 2016-12-22 02:50:20 +0000 |
---|---|---|
committer | George Burgess IV <george.burgess.iv@gmail.com> | 2016-12-22 02:50:20 +0000 |
commit | e37633713d93b21533d8699d0b5cf4703e3f4039 (patch) | |
tree | 21320a83b48d93d53645c55f3c1d4c5be76ffc17 /llvm/lib/Bitcode/Reader/BitcodeReader.cpp | |
parent | 9ac20a1e1073cf8eb40d8efe42e17bd3b2be4682 (diff) | |
download | llvm-e37633713d93b21533d8699d0b5cf4703e3f4039.zip llvm-e37633713d93b21533d8699d0b5cf4703e3f4039.tar.gz llvm-e37633713d93b21533d8699d0b5cf4703e3f4039.tar.bz2 |
Add the alloc_size attribute to clang, attempt 2.
This is a recommit of r290149, which was reverted in r290169 due to msan
failures. msan was failing because we were calling
`isMostDerivedAnUnsizedArray` on an invalid designator, which caused us
to read uninitialized memory. To fix this, the logic of the caller of
said function was simplified, and we now have a `!Invalid` assert in
`isMostDerivedAnUnsizedArray`, so we can catch this particular bug more
easily in the future.
Fingers crossed that this patch sticks this time. :)
Original commit message:
This patch does three things:
- Gives us the alloc_size attribute in clang, which lets us infer the
number of bytes handed back to us by malloc/realloc/calloc/any user
functions that act in a similar manner.
- Teaches our constexpr evaluator that evaluating some `const` variables
is OK sometimes. This is why we have a change in
test/SemaCXX/constant-expression-cxx11.cpp and other seemingly
unrelated tests. Richard Smith okay'ed this idea some time ago in
person.
- Uniques some Blocks in CodeGen, which was reviewed separately at
D26410. Lack of uniquing only really shows up as a problem when
combined with our new eagerness in the face of const.
llvm-svn: 290297
Diffstat (limited to 'llvm/lib/Bitcode/Reader/BitcodeReader.cpp')
0 files changed, 0 insertions, 0 deletions