diff options
author | Jonas Devlieghere <jonas@devlieghere.com> | 2024-06-21 11:29:49 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-06-21 11:29:49 -0700 |
commit | bf3e3289d67cb0fe136b0660cac39c24c9f65069 (patch) | |
tree | fd0372a4b1929096344c9c45bdae7423768d8466 /llvm/lib/Bitcode/Reader/BitcodeReader.cpp | |
parent | c8ba4119acffa518355acc751233849b3e9e0712 (diff) | |
download | llvm-bf3e3289d67cb0fe136b0660cac39c24c9f65069.zip llvm-bf3e3289d67cb0fe136b0660cac39c24c9f65069.tar.gz llvm-bf3e3289d67cb0fe136b0660cac39c24c9f65069.tar.bz2 |
[lldb] Unify Platform::ResolveExecutable (#96256)
The Platform class currently has two functions to resolve an executable:
`ResolveExecutable` and `ResolveRemoteExecutable`. The former strictly
deals with local files while the latter can handle potentially remote
files. I couldn't figure out why the distinction matters, at the latter
is a super-set of the former.
To make things even more confusion, we had a similar but not identical
implementation in RemoteAwarePlatform where its implementation of
`ResolveExecutable` could handle remote files. To top it all off, we had
copy-pasted implementation, dead code included in
`PlatformAppleSimulator` and `PlatformRemoteDarwinDevice`.
I went ahead and unified all the different implementation on the
original `ResolveRemoteExecutable` implementation. As far as I can tell,
it should work for every other platform, and the test suite (on macOS)
seems to agree with me, except for a small wording change.
Diffstat (limited to 'llvm/lib/Bitcode/Reader/BitcodeReader.cpp')
0 files changed, 0 insertions, 0 deletions