aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/Bitcode/Reader/BitcodeReader.cpp
diff options
context:
space:
mode:
authorAndrzej Warzynski <andrzej.warzynski@arm.com>2022-03-11 14:02:30 +0000
committerAndrzej Warzynski <andrzej.warzynski@arm.com>2022-03-11 16:12:36 +0000
commit85e2731aa3d440384067001a9a460a889037eb11 (patch)
tree9f0e43d26a45cb420833b297501dfd119348bcfb /llvm/lib/Bitcode/Reader/BitcodeReader.cpp
parent9ddb1a49ac08d8cd66771de56d5c3227d586b579 (diff)
downloadllvm-85e2731aa3d440384067001a9a460a889037eb11.zip
llvm-85e2731aa3d440384067001a9a460a889037eb11.tar.gz
llvm-85e2731aa3d440384067001a9a460a889037eb11.tar.bz2
[flang] Fix DYLIB builds
https://reviews.llvm.org/D120568 broke builds that set both `LLVM_BUILD_LLVM_DYLIB` and `LLVM_LINK_LLVM_DYLIB`. This patch fixes that. The build failure was caused by the fact that some LLVM libraries (which are also LLVM components) were listed directly as link-time dependencies instead of using `LINK_COMPONENTS` in CMake files. This lead to a linker invocation like this (simplified version to demonstrate the problem): ``` ld lib/libLLVM.so lib/libLLVMAnalysis.a lib/libLLVMTarget.a ``` That's problematic and unnecessary because `libLLVM.so` incorporates `libLLVMAnalysis` and `libLLVMTarget`. A correct invocation would look like this (`LLVM_LINK_LLVM_DYLIB` _is not_ set): ``` ld lib/libLLVMAnalysis.a lib/libLLVMTarget.a ``` or this (`LLVM_LINK_LLVM_DYLIB` _is_ set): ``` ld lib/libLLVM.so ``` Differential Revision: https://reviews.llvm.org/D121461
Diffstat (limited to 'llvm/lib/Bitcode/Reader/BitcodeReader.cpp')
0 files changed, 0 insertions, 0 deletions