aboutsummaryrefslogtreecommitdiff
path: root/llvm/lib/Bitcode/Reader/BitcodeReader.cpp
diff options
context:
space:
mode:
authorGeorge Rimar <grimar@accesssoftek.com>2016-12-21 08:11:49 +0000
committerGeorge Rimar <grimar@accesssoftek.com>2016-12-21 08:11:49 +0000
commit4fb6e79c65527b5617fe859c4c4a7d232281d2dd (patch)
tree0c7ef2bc0ba115c846271e352aa55453fd796cb7 /llvm/lib/Bitcode/Reader/BitcodeReader.cpp
parent86dc60d8d4c7cc720f578e4a18fa2664483bc186 (diff)
downloadllvm-4fb6e79c65527b5617fe859c4c4a7d232281d2dd.zip
llvm-4fb6e79c65527b5617fe859c4c4a7d232281d2dd.tar.gz
llvm-4fb6e79c65527b5617fe859c4c4a7d232281d2dd.tar.bz2
[ELF] - Fix use of freed memory.
It was revealed by D27831. If we have linkerscript that includes another one that sets OUTPUT for example: RUN: echo "INCLUDE \"foo.script\"" > %t.script RUN: echo "OUTPUT(\"%t.out\")" > %T/foo.script then we do: void ScriptParser::readInclude() { ... std::unique_ptr<MemoryBuffer> &MB = *MBOrErr; tokenize(MB->getMemBufferRef()); OwningMBs.push_back(std::move(MB)); } void ScriptParser::readOutput() { ... Config->OutputFile = unquote(Tok); ... } Problem is that OwningMBs are destroyed after script parser do its job. So all Toks are dead and Config->OutputFile points to destroyed data. Patch suggests to save all included scripts into using string Saver. Differential revision: https://reviews.llvm.org/D27987 llvm-svn: 290238
Diffstat (limited to 'llvm/lib/Bitcode/Reader/BitcodeReader.cpp')
0 files changed, 0 insertions, 0 deletions