diff options
author | davidtrevelyan <davidtrevelyan@users.noreply.github.com> | 2024-10-26 13:06:11 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-10-26 13:06:11 +0100 |
commit | 4102625380823e58d7b13f01b5bd979a29bce19e (patch) | |
tree | 6b690b3207f26d294e492f2e0a566765a173cae1 /llvm/lib/Bitcode/Reader/BitcodeReader.cpp | |
parent | 69ead949d08ff0bb8cbbf4f7143aaa6687830f6b (diff) | |
download | llvm-4102625380823e58d7b13f01b5bd979a29bce19e.zip llvm-4102625380823e58d7b13f01b5bd979a29bce19e.tar.gz llvm-4102625380823e58d7b13f01b5bd979a29bce19e.tar.bz2 |
[rtsan][llvm][NFC] Rename sanitize_realtime_unsafe attr to sanitize_realtime_blocking (#113155)
# What
This PR renames the newly-introduced llvm attribute
`sanitize_realtime_unsafe` to `sanitize_realtime_blocking`. Likewise,
sibling variables such as `SanitizeRealtimeUnsafe` are renamed to
`SanitizeRealtimeBlocking` respectively. There are no other functional
changes.
# Why?
- There are a number of problems that can cause a function to be
real-time "unsafe",
- we wish to communicate what problems rtsan detects and *why* they're
unsafe, and
- a generic "unsafe" attribute is, in our opinion, too broad a net -
which may lead to future implementations that need extra contextual
information passed through them in order to communicate meaningful
reasons to users.
- We want to avoid this situation and make the runtime library boundary
API/ABI as simple as possible, and
- we believe that restricting the scope of attributes to names like
`sanitize_realtime_blocking` is an effective means of doing so.
We also feel that the symmetry between `[[clang::blocking]]` and
`sanitize_realtime_blocking` is easier to follow as a developer.
# Concerns
- I'm aware that the LLVM attribute `sanitize_realtime_unsafe` has been
part of the tree for a few weeks now (introduced here:
https://github.com/llvm/llvm-project/pull/106754). Given that it hasn't
been released in version 20 yet, am I correct in considering this to not
be a breaking change?
Diffstat (limited to 'llvm/lib/Bitcode/Reader/BitcodeReader.cpp')
-rw-r--r-- | llvm/lib/Bitcode/Reader/BitcodeReader.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp index 4aea059..446c98c 100644 --- a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp +++ b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp @@ -2165,8 +2165,8 @@ static Attribute::AttrKind getAttrFromCode(uint64_t Code) { return Attribute::SanitizeNumericalStability; case bitc::ATTR_KIND_SANITIZE_REALTIME: return Attribute::SanitizeRealtime; - case bitc::ATTR_KIND_SANITIZE_REALTIME_UNSAFE: - return Attribute::SanitizeRealtimeUnsafe; + case bitc::ATTR_KIND_SANITIZE_REALTIME_BLOCKING: + return Attribute::SanitizeRealtimeBlocking; case bitc::ATTR_KIND_SPECULATIVE_LOAD_HARDENING: return Attribute::SpeculativeLoadHardening; case bitc::ATTR_KIND_SWIFT_ERROR: |