diff options
| author | Jakub Kuderski <kubakuderski@gmail.com> | 2019-09-25 14:04:36 +0000 |
|---|---|---|
| committer | Jakub Kuderski <kubakuderski@gmail.com> | 2019-09-25 14:04:36 +0000 |
| commit | 269bd15c68cae8492b954eb146bf729c12c003ee (patch) | |
| tree | 0ae7bffb10244981e21bb8fb76a46329740c2fd0 /llvm/lib/Bitcode/Reader/BitcodeReader.cpp | |
| parent | c5d90e4b5cf8842746f359e45047f569b9325adb (diff) | |
| download | llvm-269bd15c68cae8492b954eb146bf729c12c003ee.zip llvm-269bd15c68cae8492b954eb146bf729c12c003ee.tar.gz llvm-269bd15c68cae8492b954eb146bf729c12c003ee.tar.bz2 | |
[Dominators][AMDGPU] Don't use virtual exit node in findNearestCommonDominator. Cleanup MachinePostDominators.
Summary:
This patch fixes a bug that originated from passing a virtual exit block (nullptr) to `MachinePostDominatorTee::findNearestCommonDominator` and resulted in assertion failures inside its callee. It also applies a small cleanup to the class.
The patch introduces a new function in PDT that given a list of `MachineBasicBlock`s finds their NCD. The new overload of `findNearestCommonDominator` handles virtual root correctly.
Note that similar handling of virtual root nodes is not necessary in (forward) `DominatorTree`s, as right now they don't use virtual roots.
Reviewers: tstellar, tpr, nhaehnle, arsenm, NutshellySima, grosser, hliao
Reviewed By: hliao
Subscribers: hliao, kzhuravl, jvesely, wdng, yaxunl, dstuttard, t-tye, hiraditya, llvm-commits
Tags: #amdgpu, #llvm
Differential Revision: https://reviews.llvm.org/D67974
llvm-svn: 372874
Diffstat (limited to 'llvm/lib/Bitcode/Reader/BitcodeReader.cpp')
0 files changed, 0 insertions, 0 deletions