diff options
| author | Oliver Bruns <obruns@gmail.com> | 2020-04-06 10:38:30 +0200 |
|---|---|---|
| committer | Raphael Isemann <teemperor@gmail.com> | 2020-04-06 10:48:25 +0200 |
| commit | ad7211df6f257e39da2e5a11b2456b4488f32a1e (patch) | |
| tree | f99e36928a0d1f1a2497c99010919e24f702047d /llvm/lib/Bitcode/Reader/BitcodeAnalyzer.cpp | |
| parent | 3c2dc28d812c917e01f46b3bcf5b5e0a2a803276 (diff) | |
| download | llvm-ad7211df6f257e39da2e5a11b2456b4488f32a1e.zip llvm-ad7211df6f257e39da2e5a11b2456b4488f32a1e.tar.gz llvm-ad7211df6f257e39da2e5a11b2456b4488f32a1e.tar.bz2 | |
[clang] fix undefined behaviour in RawComment::getFormattedText()
Summary:
Calling `back()` and `pop_back()` on the empty string is undefined
behavior [1,2].
The issue manifested itself as an uncaught `std::out_of_range` exception
when running `clangd` compiled on RHEL7 using devtoolset-9.
[1] https://en.cppreference.com/w/cpp/string/basic_string/back
[2] https://en.cppreference.com/w/cpp/string/basic_string/pop_back
Fixes: 1ff7c32fc91c607b690d4bb9cf42f406be8dde68
Reviewers: teemperor, ioeric, cfe-commits
Reviewed By: teemperor
Subscribers: ilya-biryukov, kadircet, usaxena95
Tags: #clang
Differential Revision: https://reviews.llvm.org/D77468
Diffstat (limited to 'llvm/lib/Bitcode/Reader/BitcodeAnalyzer.cpp')
0 files changed, 0 insertions, 0 deletions