diff options
author | David Woodhouse <dwmw2@infradead.org> | 2014-01-13 14:05:59 +0000 |
---|---|---|
committer | David Woodhouse <dwmw2@infradead.org> | 2014-01-13 14:05:59 +0000 |
commit | 4e033b0e92aeb529e36b7390e9ab6e4d3b9eb90a (patch) | |
tree | 18705e7334beae5a0d9611e8389ad6a9c03b70ba /llvm/lib/Bitcode/Reader/BitReader.cpp | |
parent | 85bde4cdd8a5787db528e40b72da01d736154144 (diff) | |
download | llvm-4e033b0e92aeb529e36b7390e9ab6e4d3b9eb90a.zip llvm-4e033b0e92aeb529e36b7390e9ab6e4d3b9eb90a.tar.gz llvm-4e033b0e92aeb529e36b7390e9ab6e4d3b9eb90a.tar.bz2 |
[x86] Fix retq/retl handling in 64-bit mode
This finishes the job started in r198756, and creates separate opcodes for
64-bit vs. 32-bit versions of the rest of the RET instructions too.
LRETL/LRETQ are interesting... I can't see any justification for their
existence in the SDM. There should be no 'LRETL' in 64-bit mode, and no
need for a REX.W prefix for LRETQ. But this is what GAS does, and my
Sandybridge CPU and an Opteron 6376 concur when tested as follows:
asm __volatile__("pushq $0x1234\nmovq $0x33,%rax\nsalq $32,%rax\norq $1f,%rax\npushq %rax\nlretl $8\n1:");
asm __volatile__("pushq $1234\npushq $0x33\npushq $1f\nlretq $8\n1:");
asm __volatile__("pushq $0x33\npushq $1f\nlretq\n1:");
asm __volatile__("pushq $0x1234\npushq $0x33\npushq $1f\nlretq $8\n1:");
cf. PR8592 and commit r118903, which added LRETQ. I only added LRETIQ to
match it.
I don't quite understand how the Intel syntax parsing for ret
instructions is working, despite r154468 allegedly fixing it. Aren't the
explicitly sized 'retw', 'retd' and 'retq' supposed to work? I have at
least made the 'lretq' work with (and indeed *require*) the 'q'.
llvm-svn: 199106
Diffstat (limited to 'llvm/lib/Bitcode/Reader/BitReader.cpp')
0 files changed, 0 insertions, 0 deletions