diff options
author | Andrew Rogers <andrurogerz@gmail.com> | 2025-05-27 15:14:20 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-05-27 15:14:20 -0700 |
commit | d4d4a04771e183e6385919b72ba8206da87e1f9c (patch) | |
tree | 074ce8520dcaeb4d56913161b40ce9ba5f98b55e /llvm/lib/Analysis/ModuleSummaryAnalysis.cpp | |
parent | 0354491bea04beb6d1db44f8ca522bfc597ab0d3 (diff) | |
download | llvm-d4d4a04771e183e6385919b72ba8206da87e1f9c.zip llvm-d4d4a04771e183e6385919b72ba8206da87e1f9c.tar.gz llvm-d4d4a04771e183e6385919b72ba8206da87e1f9c.tar.bz2 |
[llvm] annotate interfaces in llvm/Analysis for DLL export (#136623)
## Purpose
This patch is one in a series of code-mods that annotate LLVM’s public
interface for export. This patch annotates the `llvm/Analysis` library.
These annotations currently have no meaningful impact on the LLVM build;
however, they are a prerequisite to support an LLVM Windows DLL (shared
library) build.
## Background
This effort is tracked in #109483. Additional context is provided in
[this
discourse](https://discourse.llvm.org/t/psa-annotating-llvm-public-interface/85307),
and documentation for `LLVM_ABI` and related annotations is found in the
LLVM repo
[here](https://github.com/llvm/llvm-project/blob/main/llvm/docs/InterfaceExportAnnotations.rst).
The bulk of these changes were generated automatically using the
[Interface Definition Scanner (IDS)](https://github.com/compnerd/ids)
tool, followed formatting with `git clang-format`.
The following manual adjustments were also applied after running IDS on
Linux:
- Add `#include "llvm/Support/Compiler.h"` to files where it was not
auto-added by IDS due to no pre-existing block of include statements.
- Add `LLVM_TEMPLATE_ABI` and `LLVM_EXPORT_TEMPLATE` to exported
instantiated templates
- Add `LLVM_ABI` to a subset of private class methods and fields that
require export
- Add `LLVM_ABI` to a small number of symbols that require export but
are not declared in headers
## Validation
Local builds and tests to validate cross-platform compatibility. This
included llvm, clang, and lldb on the following configurations:
- Windows with MSVC
- Windows with Clang
- Linux with GCC
- Linux with Clang
- Darwin with Clang
Diffstat (limited to 'llvm/lib/Analysis/ModuleSummaryAnalysis.cpp')
-rw-r--r-- | llvm/lib/Analysis/ModuleSummaryAnalysis.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/llvm/lib/Analysis/ModuleSummaryAnalysis.cpp b/llvm/lib/Analysis/ModuleSummaryAnalysis.cpp index d7e12dc..59fa1a4 100644 --- a/llvm/lib/Analysis/ModuleSummaryAnalysis.cpp +++ b/llvm/lib/Analysis/ModuleSummaryAnalysis.cpp @@ -51,6 +51,7 @@ #include "llvm/Pass.h" #include "llvm/Support/Casting.h" #include "llvm/Support/CommandLine.h" +#include "llvm/Support/Compiler.h" #include "llvm/Support/FileSystem.h" #include <cassert> #include <cstdint> @@ -85,7 +86,7 @@ static cl::opt<bool> EnableMemProfIndirectCallSupport( cl::desc( "Enable MemProf support for summarizing and cloning indirect calls")); -extern cl::opt<bool> ScalePartialSampleProfileWorkingSetSize; +LLVM_ABI extern cl::opt<bool> ScalePartialSampleProfileWorkingSetSize; extern cl::opt<unsigned> MaxNumVTableAnnotations; |