diff options
| author | Florian Hahn <flo@fhahn.com> | 2024-07-04 10:00:04 +0100 |
|---|---|---|
| committer | Florian Hahn <flo@fhahn.com> | 2024-07-04 10:00:05 +0100 |
| commit | 28be3f8ac51e62610f8e78b411adf05a2365dff7 (patch) | |
| tree | c9be44f39824b195ec5454c36b02c30951c2566d /llvm/lib/Analysis/LoopAccessAnalysis.cpp | |
| parent | 4002e380d0f7c689df7d26d9637118c2c7c6f985 (diff) | |
| download | llvm-28be3f8ac51e62610f8e78b411adf05a2365dff7.zip llvm-28be3f8ac51e62610f8e78b411adf05a2365dff7.tar.gz llvm-28be3f8ac51e62610f8e78b411adf05a2365dff7.tar.bz2 | |
[LAA] Cache pointer bounds expansions (NFCI).
This avoids expanding the same bounds multiple times, which helps reduce
the compile-time impact of removing the restrictions added in
234cc40adc6, notably -0.06% on stage1-O3 and -0.05% on both
stage1-ReleaseThinLTO and stage1-ReleaseLTO-g.
https://llvm-compile-time-tracker.com/compare.php?from=8b9ebc4bb86cf0979e05908cbb04336f2d01dda5&to=fabd36f96c31e47ea72653f5a404feaadfc7b5b5&stat=instructions:u
Diffstat (limited to 'llvm/lib/Analysis/LoopAccessAnalysis.cpp')
| -rw-r--r-- | llvm/lib/Analysis/LoopAccessAnalysis.cpp | 25 |
1 files changed, 16 insertions, 9 deletions
diff --git a/llvm/lib/Analysis/LoopAccessAnalysis.cpp b/llvm/lib/Analysis/LoopAccessAnalysis.cpp index 38bf6d8..f132e45 100644 --- a/llvm/lib/Analysis/LoopAccessAnalysis.cpp +++ b/llvm/lib/Analysis/LoopAccessAnalysis.cpp @@ -203,11 +203,18 @@ RuntimeCheckingPtrGroup::RuntimeCheckingPtrGroup( /// /// There is no conflict when the intervals are disjoint: /// NoConflict = (P2.Start >= P1.End) || (P1.Start >= P2.End) -static std::pair<const SCEV *, const SCEV *> -getStartAndEndForAccess(const Loop *Lp, const SCEV *PtrExpr, Type *AccessTy, - PredicatedScalarEvolution &PSE) { +static std::pair<const SCEV *, const SCEV *> getStartAndEndForAccess( + const Loop *Lp, const SCEV *PtrExpr, Type *AccessTy, + PredicatedScalarEvolution &PSE, + DenseMap<const SCEV *, std::pair<const SCEV *, const SCEV *>> + &PointerBounds) { ScalarEvolution *SE = PSE.getSE(); + auto [Iter, Ins] = PointerBounds.insert( + {PtrExpr, {SE->getCouldNotCompute(), SE->getCouldNotCompute()}}); + if (!Ins) + return Iter->second; + const SCEV *ScStart; const SCEV *ScEnd; @@ -244,7 +251,8 @@ getStartAndEndForAccess(const Loop *Lp, const SCEV *PtrExpr, Type *AccessTy, const SCEV *EltSizeSCEV = SE->getStoreSizeOfExpr(IdxTy, AccessTy); ScEnd = SE->getAddExpr(ScEnd, EltSizeSCEV); - return {ScStart, ScEnd}; + Iter->second = {ScStart, ScEnd}; + return Iter->second; } /// Calculate Start and End points of memory access using @@ -254,8 +262,8 @@ void RuntimePointerChecking::insert(Loop *Lp, Value *Ptr, const SCEV *PtrExpr, unsigned DepSetId, unsigned ASId, PredicatedScalarEvolution &PSE, bool NeedsFreeze) { - const auto &[ScStart, ScEnd] = - getStartAndEndForAccess(Lp, PtrExpr, AccessTy, PSE); + const auto &[ScStart, ScEnd] = getStartAndEndForAccess( + Lp, PtrExpr, AccessTy, PSE, DC.getPointerBounds()); assert(!isa<SCEVCouldNotCompute>(ScStart) && !isa<SCEVCouldNotCompute>(ScEnd) && "must be able to compute both start and end expressions"); @@ -1964,10 +1972,9 @@ MemoryDepChecker::getDependenceDistanceStrideAndSize( if (SE.isLoopInvariant(Src, InnermostLoop) || SE.isLoopInvariant(Sink, InnermostLoop)) { const auto &[SrcStart, SrcEnd] = - getStartAndEndForAccess(InnermostLoop, Src, ATy, PSE); + getStartAndEndForAccess(InnermostLoop, Src, ATy, PSE, PointerBounds); const auto &[SinkStart, SinkEnd] = - getStartAndEndForAccess(InnermostLoop, Sink, BTy, PSE); - + getStartAndEndForAccess(InnermostLoop, Sink, BTy, PSE, PointerBounds); if (!isa<SCEVCouldNotCompute>(SrcStart) && !isa<SCEVCouldNotCompute>(SrcEnd) && !isa<SCEVCouldNotCompute>(SinkStart) && |