diff options
author | Liqiang Tao <taolq@outlook.com> | 2021-03-31 19:52:58 +0800 |
---|---|---|
committer | Liqiang Tao <taolq@outlook.com> | 2021-03-31 20:11:32 +0800 |
commit | d2d6720a93a2469fb3a752bd59674bd2cf97d91f (patch) | |
tree | 3f482a0e3d09d73ef0b65382694a274374a16f52 /llvm/lib/Analysis/InlineCost.cpp | |
parent | ce548aa236962f95ccaf59f8692ed0861f3769dd (diff) | |
download | llvm-d2d6720a93a2469fb3a752bd59674bd2cf97d91f.zip llvm-d2d6720a93a2469fb3a752bd59674bd2cf97d91f.tar.gz llvm-d2d6720a93a2469fb3a752bd59674bd2cf97d91f.tar.bz2 |
[InlineCost] Remove TODO comment that consider other forms of savings in the cost-benefit analysis
Attempts to compute savings more accurately cannot impact the set of critically important call sites.
Reviewed By: kazu
Differential Revision: https://reviews.llvm.org/D98577
Diffstat (limited to 'llvm/lib/Analysis/InlineCost.cpp')
-rw-r--r-- | llvm/lib/Analysis/InlineCost.cpp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/llvm/lib/Analysis/InlineCost.cpp b/llvm/lib/Analysis/InlineCost.cpp index 06e4d9b..06cc778 100644 --- a/llvm/lib/Analysis/InlineCost.cpp +++ b/llvm/lib/Analysis/InlineCost.cpp @@ -761,9 +761,6 @@ class InlineCostCallAnalyzer final : public CallAnalyzer { CurrentSavings += InlineConstants::InstrCost; } } - // TODO: Consider other forms of savings like switch statements, - // indirect calls becoming direct, SROACostSavings, LoadEliminationCost, - // etc. } auto ProfileCount = CalleeBFI->getBlockProfileCount(&BB); |