diff options
| author | Alex Langford <alangford@apple.com> | 2023-04-17 16:11:07 -0700 |
|---|---|---|
| committer | Alex Langford <alangford@apple.com> | 2023-04-17 17:25:05 -0700 |
| commit | 8bddb13c2470b95651955c61913627b31e9c99d6 (patch) | |
| tree | b66310e7c607ccbea8f3c9f760414dd1a3126afc /lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp | |
| parent | 8c2276f89887d0a27298a1bbbd2181fa54bbb509 (diff) | |
| download | llvm-8bddb13c2470b95651955c61913627b31e9c99d6.zip llvm-8bddb13c2470b95651955c61913627b31e9c99d6.tar.gz llvm-8bddb13c2470b95651955c61913627b31e9c99d6.tar.bz2 | |
[lldb] Change parameter type of StructuredData::ParseJSON
Instead of taking a `const std::string &` we can take an
`llvm::StringRef`. The motivation for this change is that many of the
callers of `ParseJSON` end up creating a temporary `std::string` from an existing
`StringRef` or `const char *` in order to satisfy the API. There's no
reason we need to do this.
Differential Revision: https://reviews.llvm.org/D148579
Diffstat (limited to 'lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp')
| -rw-r--r-- | lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp b/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp index f3eea28..bf43881 100644 --- a/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp +++ b/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp @@ -287,7 +287,7 @@ TEST_F(GDBRemoteCommunicationClientTest, TestPacketSpeedJSON) { server_thread.join(); GTEST_LOG_(INFO) << "Formatted output: " << ss.GetData(); - auto object_sp = StructuredData::ParseJSON(std::string(ss.GetString())); + auto object_sp = StructuredData::ParseJSON(ss.GetString()); ASSERT_TRUE(bool(object_sp)); auto dict_sp = object_sp->GetAsDictionary(); ASSERT_TRUE(bool(dict_sp)); |