diff options
| author | David Spickett <david.spickett@linaro.org> | 2021-06-25 09:57:46 +0000 |
|---|---|---|
| committer | David Spickett <david.spickett@linaro.org> | 2021-06-25 10:09:52 +0000 |
| commit | 6e5c4a443d7e354a37d7dcb82a65216679ab1b40 (patch) | |
| tree | f2d47fad9842a0b8b9c60247e0aa9d03dab1397c /lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp | |
| parent | 79c98279b6cdab6f208043865ab7b4ac4612cec5 (diff) | |
| download | llvm-6e5c4a443d7e354a37d7dcb82a65216679ab1b40.zip llvm-6e5c4a443d7e354a37d7dcb82a65216679ab1b40.tar.gz llvm-6e5c4a443d7e354a37d7dcb82a65216679ab1b40.tar.bz2 | |
[lldb] Re-enable GDB server client memory tag read tests
These were disabled in 473a3a773ea565612e836ae6c2093178c5a9eb72
because they failed on 32 bit platforms. (Arm for sure but I assume
any 32 bit)
This was due to the printf formatter used. These assumed
that types like uint64_t/size_t would be certain size/type and
that changes on 32 bit.
Instead use "z" to print the size_t and PRI<...> formatters
for the addr_t (always uint64_t) and the int32_t.
Diffstat (limited to 'lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp')
| -rw-r--r-- | lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp b/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp index 91e6345..b9fc107 100644 --- a/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp +++ b/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp @@ -465,7 +465,7 @@ TEST_F(GDBRemoteCommunicationClientTest, GetQOffsets) { EXPECT_EQ(llvm::None, GetQOffsets("TextSeg=0x1234")); EXPECT_EQ(llvm::None, GetQOffsets("TextSeg=12345678123456789")); } -#if 0 + static void check_qmemtags(TestClient &client, MockServer &server, size_t read_len, const char *packet, llvm::StringRef response, @@ -530,4 +530,3 @@ TEST_F(GDBRemoteCommunicationClientTest, ReadMemoryTags) { check_qmemtags(client, server, 32, "qMemTags:def0,20:1", "m01020", llvm::None); } -#endif |