diff options
| author | Roman Lebedev <lebedev.ri@gmail.com> | 2022-02-07 16:03:40 +0300 |
|---|---|---|
| committer | Roman Lebedev <lebedev.ri@gmail.com> | 2022-02-07 16:08:31 +0300 |
| commit | 77a0da926c9ea86afa9baf28158d79c7678fc6b9 (patch) | |
| tree | 4d8c0cbdddd78be78aa6ed8522a0fb71b8e42ccf /lldb/test/Shell/ScriptInterpreter/Python | |
| parent | f59787084e09aeb787cb3be3103b2419ccd14163 (diff) | |
| download | llvm-77a0da926c9ea86afa9baf28158d79c7678fc6b9.zip llvm-77a0da926c9ea86afa9baf28158d79c7678fc6b9.tar.gz llvm-77a0da926c9ea86afa9baf28158d79c7678fc6b9.tar.bz2 | |
[LV] Remove `LoopVectorizationCostModel::useEmulatedMaskMemRefHack()`
D43208 extracted `useEmulatedMaskMemRefHack()` from legality into cost model.
What it essentially does is prevents scalarized vectorization of masked memory operations:
```
// TODO: Cost model for emulated masked load/store is completely
// broken. This hack guides the cost model to use an artificially
// high enough value to practically disable vectorization with such
// operations, except where previously deployed legality hack allowed
// using very low cost values. This is to avoid regressions coming simply
// from moving "masked load/store" check from legality to cost model.
// Masked Load/Gather emulation was previously never allowed.
// Limited number of Masked Store/Scatter emulation was allowed.
```
While i don't really understand about what specifically `is completely broken`
was talking about, i believe that at least on X86 with AVX2-or-later,
this is no longer true. (or at least, i would like to know what is still broken).
So i would like to follow suit after D111460, and like wise disable that hack for AVX2+.
But since this was added for X86 specifically, let's just instead completely remove this hack.
Reviewed By: RKSimon
Differential Revision: https://reviews.llvm.org/D114779
Diffstat (limited to 'lldb/test/Shell/ScriptInterpreter/Python')
0 files changed, 0 insertions, 0 deletions
