diff options
| author | Kazu Hirata <kazu@google.com> | 2022-01-09 12:21:02 -0800 |
|---|---|---|
| committer | Kazu Hirata <kazu@google.com> | 2022-01-09 12:21:02 -0800 |
| commit | b12fd138127e368a5d78109bef77713c0bcd536e (patch) | |
| tree | 347dc8600af5f7a303cd06ba641d4d01e522c209 /lldb/source | |
| parent | ac2090d507a67d1e98594d081ce3951837d43f28 (diff) | |
| download | llvm-b12fd138127e368a5d78109bef77713c0bcd536e.tar.gz llvm-b12fd138127e368a5d78109bef77713c0bcd536e.tar.bz2 llvm-b12fd138127e368a5d78109bef77713c0bcd536e.zip | |
Fix bugprone argument comments.
Identified by bugprone-argument-comment.
Diffstat (limited to 'lldb/source')
| -rw-r--r-- | lldb/source/Breakpoint/BreakpointResolverFileRegex.cpp | 2 | ||||
| -rw-r--r-- | lldb/source/Expression/DWARFExpression.cpp | 2 | ||||
| -rw-r--r-- | lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp | 4 | ||||
| -rw-r--r-- | lldb/source/Symbol/Function.cpp | 2 | ||||
| -rw-r--r-- | lldb/source/Target/TraceInstructionDumper.cpp | 2 | ||||
| -rw-r--r-- | lldb/source/Utility/Reproducer.cpp | 2 |
6 files changed, 7 insertions, 7 deletions
diff --git a/lldb/source/Breakpoint/BreakpointResolverFileRegex.cpp b/lldb/source/Breakpoint/BreakpointResolverFileRegex.cpp index 435983769c05..4a11d82ecc6e 100644 --- a/lldb/source/Breakpoint/BreakpointResolverFileRegex.cpp +++ b/lldb/source/Breakpoint/BreakpointResolverFileRegex.cpp @@ -110,7 +110,7 @@ Searcher::CallbackReturn BreakpointResolverFileRegex::SearchCallback( // TODO: Handle SourceLocationSpec column information SourceLocationSpec location_spec(cu_file_spec, line_matches[i], /*column=*/llvm::None, - /*search_inlines=*/false, m_exact_match); + /*check_inlines=*/false, m_exact_match); cu->ResolveSymbolContext(location_spec, eSymbolContextEverything, sc_list); // Find all the function names: if (!m_function_names.empty()) { diff --git a/lldb/source/Expression/DWARFExpression.cpp b/lldb/source/Expression/DWARFExpression.cpp index 890d8b5d3107..ccd41fb4a94e 100644 --- a/lldb/source/Expression/DWARFExpression.cpp +++ b/lldb/source/Expression/DWARFExpression.cpp @@ -825,7 +825,7 @@ static bool Evaluate_DW_OP_entry_value(std::vector<Value> &stack, const DWARFExpression ¶m_expr = matched_param->LocationInCaller; if (!param_expr.Evaluate(&parent_exe_ctx, parent_frame->GetRegisterContext().get(), - /*loclist_base_addr=*/LLDB_INVALID_ADDRESS, + /*loclist_base_load_addr=*/LLDB_INVALID_ADDRESS, /*initial_value_ptr=*/nullptr, /*object_address_ptr=*/nullptr, result, error_ptr)) { LLDB_LOG(log, diff --git a/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp b/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp index d9cbcce22c52..188b6da7a712 100644 --- a/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp +++ b/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp @@ -338,7 +338,7 @@ bool DynamicLoaderPOSIXDYLD::SetRendezvousBreakpoint() { dyld_break = target.CreateBreakpoint( &containingModules, /*containingSourceFiles=*/nullptr, DebugStateCandidates, eFunctionNameTypeFull, eLanguageTypeC, - /*offset=*/0, + /*m_offset=*/0, /*skip_prologue=*/eLazyBoolNo, /*internal=*/true, /*request_hardware=*/false); @@ -348,7 +348,7 @@ bool DynamicLoaderPOSIXDYLD::SetRendezvousBreakpoint() { dyld_break = target.CreateBreakpoint( &containingModules, /*containingSourceFiles=*/nullptr, DebugStateCandidates, eFunctionNameTypeFull, eLanguageTypeC, - /*offset=*/0, + /*m_offset=*/0, /*skip_prologue=*/eLazyBoolNo, /*internal=*/true, /*request_hardware=*/false); diff --git a/lldb/source/Symbol/Function.cpp b/lldb/source/Symbol/Function.cpp index 37479651fb45..dda9ec232715 100644 --- a/lldb/source/Symbol/Function.cpp +++ b/lldb/source/Symbol/Function.cpp @@ -195,7 +195,7 @@ Function *IndirectCallEdge::GetCallee(ModuleList &images, Status error; Value callee_addr_val; if (!call_target.Evaluate(&exe_ctx, exe_ctx.GetRegisterContext(), - /*loclist_base_addr=*/LLDB_INVALID_ADDRESS, + /*loclist_base_load_addr=*/LLDB_INVALID_ADDRESS, /*initial_value_ptr=*/nullptr, /*object_address_ptr=*/nullptr, callee_addr_val, &error)) { diff --git a/lldb/source/Target/TraceInstructionDumper.cpp b/lldb/source/Target/TraceInstructionDumper.cpp index dc1e86481c36..69d59dcfb12f 100644 --- a/lldb/source/Target/TraceInstructionDumper.cpp +++ b/lldb/source/Target/TraceInstructionDumper.cpp @@ -137,7 +137,7 @@ DumpInstructionSymbolContext(Stream &s, insn.sc.module_sp->GetFileSpec().GetFilename().AsCString()); else insn.sc.DumpStopContext(&s, insn.exe_ctx.GetTargetPtr(), insn.address, - /*show_fullpath=*/false, + /*show_fullpaths=*/false, /*show_module=*/true, /*show_inlined_frames=*/false, /*show_function_arguments=*/true, /*show_function_name=*/true); diff --git a/lldb/source/Utility/Reproducer.cpp b/lldb/source/Utility/Reproducer.cpp index a306d6c1ef25..1e71dba472ed 100644 --- a/lldb/source/Utility/Reproducer.cpp +++ b/lldb/source/Utility/Reproducer.cpp @@ -362,7 +362,7 @@ llvm::Error repro::Finalize(Loader *loader) { FileSpec mapping = reproducer_root.CopyByAppendingPathComponent(FileProvider::Info::file); - if (auto ec = collector.copyFiles(/*stop_on_error=*/false)) + if (auto ec = collector.copyFiles(/*StopOnError=*/false)) return errorCodeToError(ec); collector.writeMapping(mapping.GetPath()); |
