[Reproducers] Stop recording instead of deallocating

The command interpreter holds a pointer to a DataRecorder. After
generating the reproducer, we deallocated all the DataRecorders, causing
the command interpreter to hold a non-null reference to an invalid
object.

This patch changes the behavior of the command provider to stop the
DataRecorders when a reproducer is generated, rather than deallocating
them.

llvm-svn: 355940

1 files changed, 3 insertions, 1 deletions

diff --git a/lldb/source/Utility/Reproducer.cpp b/lldb/source/Utility/Reproducer.cpp
index 3e2ffcda281c..20d255e0019e 100644
--- a/lldb/source/Utility/Reproducer.cpp
+++ b/lldb/source/Utility/Reproducer.cpp
@@ -247,8 +247,10 @@ DataRecorder *CommandProvider::GetNewDataRecorder() {
 
 void CommandProvider::Keep() {
   std::vector<std::string> files;
-  for (auto &recorder : m_data_recorders)
+  for (auto &recorder : m_data_recorders) {
+    recorder->Stop();
     files.push_back(recorder->GetFilename().GetPath());
+  }
 
   FileSpec file = GetRoot().CopyByAppendingPathComponent(info::file);
   std::error_code ec;