Rewrite all Property related functions in terms of StringRef.

This was a bit tricky, especially for things like
OptionValueArray and OptionValueDictionary since they do some
funky string parsing.  Rather than try to re-write line-by-line
I tried to make the StringRef usage idiomatic, even though
it meant often re-writing from scratch large blocks of code
in a different way while keeping true to the original intent.

The finished code is a big improvement though, and often much
shorter than the original code.  All tests and unit tests
pass on Windows and Linux.

llvm-svn: 287242

1 files changed, 4 insertions, 7 deletions

diff --git a/lldb/source/Target/ProcessInfo.cpp b/lldb/source/Target/ProcessInfo.cpp
index 4b02332f4d9f..5c4b2f07e426 100644
--- a/lldb/source/Target/ProcessInfo.cpp
+++ b/lldb/source/Target/ProcessInfo.cpp
@@ -78,15 +78,12 @@ void ProcessInfo::SetExecutableFile(const FileSpec &exe_file,
   }
 }
 
-const char *ProcessInfo::GetArg0() const {
-  return (m_arg0.empty() ? nullptr : m_arg0.c_str());
+llvm::StringRef ProcessInfo::GetArg0() const {
+  return m_arg0;
 }
 
-void ProcessInfo::SetArg0(const char *arg) {
-  if (arg && arg[0])
-    m_arg0 = arg;
-  else
-    m_arg0.clear();
+void ProcessInfo::SetArg0(llvm::StringRef arg) {
+  m_arg0 = arg;
 }
 
 void ProcessInfo::SetArguments(char const **argv,