diff options
| author | Jacob Lalonde <jalalonde@fb.com> | 2024-08-21 10:25:23 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-21 10:25:23 -0700 |
| commit | 6cb14599ade843be3171fa7e4dd5f3601a3bb0de (patch) | |
| tree | cb99bd15dff75ce036913d6298cf2586e555a9f6 /lldb/source/Plugins/ScriptInterpreter/Python | |
| parent | e78156a0e225673e592920410c8cadc94f19aa66 (diff) | |
| download | llvm-6cb14599ade843be3171fa7e4dd5f3601a3bb0de.zip llvm-6cb14599ade843be3171fa7e4dd5f3601a3bb0de.tar.gz llvm-6cb14599ade843be3171fa7e4dd5f3601a3bb0de.tar.bz2 | |
[LLDB][Minidump] Fix ProcessMinidump::GetMemoryRegions to include 64b regions when /proc/pid maps are missing. (#101086)
This PR is in response to a bug my coworker @mbucko discovered where on
MacOS Minidumps were being created where the 64b memory regions were
readable, but were not being listed in
`SBProcess.GetMemoryRegionList()`. This went unnoticed in #95312 due to
all the linux testing including /proc/pid maps. On MacOS generated dumps
(or any dump without access to /proc/pid) we would fail to properly map
Memory Regions due to there being two independent methods for 32b and
64b mapping.
In this PR I addressed this minor bug and merged the methods, but in
order to add test coverage required additions to `obj2yaml` and
`yaml2obj` which make up the bulk of this patch.
Lastly, there are some non-required changes such as the addition of the
`Memory64ListHeader` type, to make writing/reading the header section of
the Memory64List easier.
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python')
0 files changed, 0 insertions, 0 deletions
