diff options
author | Lawrence D'Anna <lawrence_danna@apple.com> | 2019-10-29 13:42:38 -0700 |
---|---|---|
committer | Lawrence D'Anna <lawrence_danna@apple.com> | 2019-10-29 15:03:02 -0700 |
commit | a69bbe02a2352271e8b14542073f177e24c499c1 (patch) | |
tree | 35235c75e8d75a9a9b0c52719b150ca4f9435e2d /lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h | |
parent | 98286b569d01a461d75c9fd133cbf52c0c92e32a (diff) | |
download | llvm-a69bbe02a2352271e8b14542073f177e24c499c1.zip llvm-a69bbe02a2352271e8b14542073f177e24c499c1.tar.gz llvm-a69bbe02a2352271e8b14542073f177e24c499c1.tar.bz2 |
[LLDB][breakpoints] ArgInfo::count -> ArgInfo::max_positional_args
Summary:
Move breakpoints from the old, bad ArgInfo::count to the new, better
ArgInfo::max_positional_args. Soon ArgInfo::count will be no more.
It looks like this functionality is already well tested by
`TestBreakpointCommandsFromPython.py`, so there's no need to write
additional tests for it.
Reviewers: labath, jingham, JDevlieghere
Reviewed By: labath
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D69468
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h')
-rw-r--r-- | lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h b/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h index e480bc3..7983049 100644 --- a/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h +++ b/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h @@ -256,11 +256,10 @@ public: BreakpointOptions *bp_options, std::unique_ptr<BreakpointOptions::CommandData> &data_up) override; - Status SetBreakpointCommandCallback( - BreakpointOptions *bp_options, - const char *command_body_text, - StructuredData::ObjectSP extra_args_sp, - bool uses_extra_args); + Status SetBreakpointCommandCallback(BreakpointOptions *bp_options, + const char *command_body_text, + StructuredData::ObjectSP extra_args_sp, + bool uses_extra_args); /// Set a one-liner as the callback for the watchpoint. void SetWatchpointCommandCallback(WatchpointOptions *wp_options, @@ -378,10 +377,9 @@ public: python::PythonDictionary &GetSessionDictionary(); python::PythonDictionary &GetSysModuleDictionary(); - - llvm::Expected<size_t> - GetNumFixedArgumentsForCallable(const llvm::StringRef &callable_name) - override; + + llvm::Expected<unsigned> GetMaxPositionalArgumentsForCallable( + const llvm::StringRef &callable_name) override; bool GetEmbeddedInterpreterModuleObjects(); |