aboutsummaryrefslogtreecommitdiff
path: root/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
diff options
context:
space:
mode:
authorHarini0924 <79345568+Harini0924@users.noreply.github.com>2024-08-26 20:34:32 -0700
committerGitHub <noreply@github.com>2024-08-26 20:34:32 -0700
commit823e94299875e040dfde62776297333033f83dd2 (patch)
tree08e4ddd1a2224c7ac6dbc38b8b6a09aa54145da7 /lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
parentd28c0fb186dad157daf00a8a43a34daa49593cda (diff)
downloadllvm-823e94299875e040dfde62776297333033f83dd2.zip
llvm-823e94299875e040dfde62776297333033f83dd2.tar.gz
llvm-823e94299875e040dfde62776297333033f83dd2.tar.bz2
[compiler-rt][test] Expand and Rewrite Tests for lit Internal Shell Compatibility (#106115)
This patch addresses compatibility issues with the lit internal shell by expanding and rewriting test scripts in the compiler-rt subproject. These changes were prompted by the FileNotFound unresolved errors encountered during the testing process, specifically when running the command `LIT_USE_INTERNAL_SHELL=1 ninja check compiler-rt`. **Why the error occurred:** The error occurred because the original test scripts used process substitution `(<(...))` in their diff commands. Process substitution creates temporary files or FIFOs to hold command output, and these are then passed to `diff`. However, the lit internal shell, which is more limited than a typical shell like `bash`, does not support process substitution. When lit tries to execute these commands, it is unable to create or access the temporary files or FIFOs generated by process substitution. As a result, lit attempts to open a file or directory that doesn't exist, leading to the `FileNotFoundError`. **Changes Made:** - Instead of using process substitution, the commands now explicitly redirect the output of `llvm-profdata show` to temporary files before performing the `diff` comparison. This ensures that the lit internal shell can correctly find and open these files, resolving the `FileNotFoundError`. [This change is relevant [RFC] Enabling the lit internal shell by Default](https://discourse.llvm.org/t/rfc-enabling-the-lit-internal-shell-by-default/80179) fixes: #106111
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp')
0 files changed, 0 insertions, 0 deletions