diff options
| author | Davide Italiano <ditaliano@apple.com> | 2020-04-07 12:41:31 -0700 |
|---|---|---|
| committer | Davide Italiano <ditaliano@apple.com> | 2020-04-07 12:43:25 -0700 |
| commit | 30a292c25df327eb35b341b919c4e9b5e80323be (patch) | |
| tree | cb17cb946f779891997be32611b4edeea1d1246c /lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp | |
| parent | f9d558c871337699d2815dbf116bae94025f5d90 (diff) | |
| download | llvm-30a292c25df327eb35b341b919c4e9b5e80323be.zip llvm-30a292c25df327eb35b341b919c4e9b5e80323be.tar.gz llvm-30a292c25df327eb35b341b919c4e9b5e80323be.tar.bz2 | |
[ScriptInterpreterPython] Remove buggy code to save/restore stdin.
Discussed on lldb-dev with Pavel Labath. This doesn't work for
background processes [causes Python to be stuck forever], and it's
unclear whether it's needed. There's no test, also. If this turns
out to be useful, it can be recommitted with a functional implementation
and a test.
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp')
| -rw-r--r-- | lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp b/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp index ee94a18..c53b3bd 100644 --- a/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp +++ b/lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp @@ -224,10 +224,6 @@ struct InitializePythonRAII { public: InitializePythonRAII() : m_gil_state(PyGILState_UNLOCKED), m_was_already_initialized(false) { - // Python will muck with STDIN terminal state, so save off any current TTY - // settings so we can restore them. - m_stdin_tty_state.Save(STDIN_FILENO, false); - InitializePythonHome(); #ifdef LLDB_USE_LIBEDIT_READLINE_COMPAT_MODULE @@ -271,8 +267,6 @@ public: // We initialized the threads in this function, just unlock the GIL. PyEval_SaveThread(); } - - m_stdin_tty_state.Restore(); } private: |