diff options
| author | Georgii Rymar <grimar@accesssoftek.com> | 2020-11-30 15:38:42 +0300 |
|---|---|---|
| committer | Georgii Rymar <grimar@accesssoftek.com> | 2020-12-02 13:51:32 +0300 |
| commit | 137a25f04a515e5ea8f24c897e34b4cd236239a8 (patch) | |
| tree | 27100256641d3b6268a70af90003c6d983cc5442 /lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp | |
| parent | 14557cdf9427341e60b9bd34807c46b2ee826f99 (diff) | |
| download | llvm-137a25f04a515e5ea8f24c897e34b4cd236239a8.zip llvm-137a25f04a515e5ea8f24c897e34b4cd236239a8.tar.gz llvm-137a25f04a515e5ea8f24c897e34b4cd236239a8.tar.bz2 | |
[llvm-readobj, libSupport] - Refine the implementation of the code that dumps build attributes.
This implementation of `ELFDumper<ELFT>::printAttributes()` in llvm-readobj has issues:
1) It crashes when the content of the attribute section is empty.
2) It uses `unwrapOrError` and `reportWarning` calls, though
ideally we want to use `reportUniqueWarning`.
3) It contains a TODO about redundant format version check.
`lib/Support/ELFAttributeParser.cpp` uses a hardcoded constant instead of the named constant.
This patch fixes all these issues.
Differential revision: https://reviews.llvm.org/D92318
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp')
0 files changed, 0 insertions, 0 deletions